remove t2 cap, add minor timing tweaks
This commit is contained in:
@@ -109,8 +109,6 @@ typedef enum {
|
||||
KipConfigValue_low_t7_tWTR,
|
||||
KipConfigValue_low_t8_tREFI,
|
||||
|
||||
KipConfigValue_t2_tRP_cap,
|
||||
|
||||
KipConfigValue_read_latency_1333,
|
||||
KipConfigValue_read_latency_1600,
|
||||
KipConfigValue_read_latency_1866,
|
||||
@@ -391,9 +389,6 @@ static inline const char* hocclkFormatConfigValue(HocClkConfigValue val, bool pr
|
||||
case KipConfigValue_low_t8_tREFI:
|
||||
return pretty ? "Low T8 - tREFI" : "low_t7_tREFI";
|
||||
|
||||
case KipConfigValue_t2_tRP_cap:
|
||||
return pretty ? "t2 - trp 1333WL Cap" : "t2_tRP_cap";
|
||||
|
||||
case KipConfigValue_read_latency_1333:
|
||||
return pretty ? "1333 Read Latency" : "read_latency_1333";
|
||||
case KipConfigValue_read_latency_1600:
|
||||
@@ -666,7 +661,6 @@ static inline uint64_t hocclkValidConfigValue(HocClkConfigValue val, uint64_t in
|
||||
case KipConfigValue_low_t6_tRTW:
|
||||
case KipConfigValue_low_t7_tWTR:
|
||||
case KipConfigValue_low_t8_tREFI:
|
||||
case KipConfigValue_t2_tRP_cap:
|
||||
case KipConfigValue_read_latency_1333:
|
||||
case KipConfigValue_read_latency_1600:
|
||||
case KipConfigValue_read_latency_1866:
|
||||
|
||||
@@ -320,13 +320,6 @@ std::vector<std::string> ConfigInfoStrings(HocClkConfigValue val, bool isMariko,
|
||||
"Write To Read (Low bracket)",
|
||||
"Default: 0"
|
||||
};
|
||||
case KipConfigValue_t2_tRP_cap:
|
||||
return {
|
||||
"Cap for t2 when 1333WL is used.",
|
||||
"The default value is sufficient for most RAMs but some may need a lower value",
|
||||
"Default: 2"
|
||||
};
|
||||
|
||||
case KipConfigValue_t6_tRTW_fine_tune:
|
||||
return {
|
||||
"Fine-tunes the raw calculation of t6",
|
||||
|
||||
@@ -1424,12 +1424,10 @@ class RamTimingsSubmenuGui : public MiscGui {
|
||||
const s32 t7 = (s32)cfgPtr->values[KipConfigValue_t7_tWTR];
|
||||
const s32 lt6 = (s32)cfgPtr->values[KipConfigValue_low_t6_tRTW];
|
||||
const s32 lt7 = (s32)cfgPtr->values[KipConfigValue_low_t7_tWTR];
|
||||
const s32 t2c = (s32)cfgPtr->values[KipConfigValue_t2_tRP_cap];
|
||||
const uint32_t tbk = (uint32_t)cfgPtr->values[KipConfigValue_timingEmcTbreak];
|
||||
|
||||
const tsl::Color cT6 = tsl::Color(4, 14, 15, 15);
|
||||
const tsl::Color cT7 = tsl::Color(15, 9, 2, 15);
|
||||
const tsl::Color cT2 = tsl::Color(12, 4, 15, 15);
|
||||
const tsl::Color cAxis = tsl::Color(5, 5, 5, 15);
|
||||
const tsl::Color cTbk = tsl::Color(7, 7, 7, 10);
|
||||
|
||||
@@ -1495,12 +1493,6 @@ class RamTimingsSubmenuGui : public MiscGui {
|
||||
drawTimingLine(lt6, t6, cT6);
|
||||
drawTimingLine(lt7, t7, cT7);
|
||||
|
||||
// t2 tRP cap: constant line
|
||||
s32 yT2 = valY(t2c) + 1;
|
||||
renderer->drawRect(gx, yT2, gw, 2, cT2);
|
||||
renderer->drawCircle(gx, yT2 + 1, 3, true, cT2);
|
||||
renderer->drawCircle(gx + gw - 1, yT2 + 1, 3, true, cT2);
|
||||
|
||||
// X-axis ruler with sideways bitmap-font labels
|
||||
static const uint8_t kDigBmp[10][5] = {
|
||||
{ 7, 5, 5, 5, 7 }, { 6, 2, 2, 2, 7 }, { 7, 1, 7, 4, 7 }, { 7, 1, 3, 1, 7 }, { 5, 5, 7, 1, 1 },
|
||||
@@ -1537,15 +1529,12 @@ class RamTimingsSubmenuGui : public MiscGui {
|
||||
renderer->drawString("t6 tRTW", false, gx + 17, ly + 5, 12, cT6);
|
||||
renderer->drawRect(gx + 80, ly, 14, 3, cT7);
|
||||
renderer->drawString("t7 tWTR", false, gx + 97, ly + 5, 12, cT7);
|
||||
renderer->drawRect(gx + 165, ly, 14, 3, cT2);
|
||||
renderer->drawString("t2 cap", false, gx + 182, ly + 5, 12, cT2);
|
||||
});
|
||||
tbreakGraph->setBoundaries(0, 0, tsl::cfg::FramebufferWidth, 150);
|
||||
this->listElement->addItem(tbreakGraph);
|
||||
}
|
||||
|
||||
addConfigButton(KipConfigValue_timingEmcTbreak, "RAM-Timing tBreak", ValueRange(0, 1, 1, "", 1), "tBreak", &thresholdsDisabled, {},
|
||||
timingTbreakFreqs, false, true);
|
||||
addConfigButton(KipConfigValue_timingEmcTbreak, "RAM-Timing tBreak", ValueRange(0, 1, 1, "", 1), "tBreak", &thresholdsDisabled, {}, timingTbreakFreqs, false, true);
|
||||
addConfigTrackbar(KipConfigValue_low_t1_tRCD, "Low t1 tRCD", ValueRange(0, 7, 1));
|
||||
addConfigTrackbar(KipConfigValue_low_t2_tRP, "Low t2 tRP", ValueRange(0, 7, 1));
|
||||
addConfigTrackbar(KipConfigValue_low_t3_tRAS, "Low t3 tRAS", ValueRange(0, 9, 1));
|
||||
@@ -1559,7 +1548,6 @@ class RamTimingsSubmenuGui : public MiscGui {
|
||||
spacer->setBoundaries(0, 0, tsl::cfg::FramebufferWidth, 8);
|
||||
this->listElement->addItem(spacer);
|
||||
}
|
||||
addConfigTrackbar(KipConfigValue_t2_tRP_cap, "1333WL t2 RP Cap", ValueRange(0, 8, 1));
|
||||
}
|
||||
addMappedConfigTrackbar(KipConfigValue_t6_tRTW_fine_tune, "t6 tRTW Fine Tune", { 0xFFFFFFFEu, 0xFFFFFFFFu, 0u, 1u, 2u },
|
||||
{ "-2", "-1", " 0", "+1", "+2" });
|
||||
|
||||
@@ -95,7 +95,6 @@ namespace kip {
|
||||
CUST_WRITE_FIELD_BATCH(&table, low_t6_tRTW, config::GetConfigValue(KipConfigValue_low_t6_tRTW));
|
||||
CUST_WRITE_FIELD_BATCH(&table, low_t7_tWTR, config::GetConfigValue(KipConfigValue_low_t7_tWTR));
|
||||
CUST_WRITE_FIELD_BATCH(&table, low_t8_tREFI, config::GetConfigValue(KipConfigValue_low_t8_tREFI));
|
||||
CUST_WRITE_FIELD_BATCH(&table, t2_tRP_cap, config::GetConfigValue(KipConfigValue_t2_tRP_cap));
|
||||
|
||||
CUST_WRITE_FIELD_BATCH(&table, readLatency1333, config::GetConfigValue(KipConfigValue_read_latency_1333));
|
||||
CUST_WRITE_FIELD_BATCH(&table, readLatency1600, config::GetConfigValue(KipConfigValue_read_latency_1600));
|
||||
@@ -281,7 +280,6 @@ namespace kip {
|
||||
configValues.values[KipConfigValue_low_t6_tRTW] = cust_get_low_tRTW(&table);
|
||||
configValues.values[KipConfigValue_low_t7_tWTR] = cust_get_low_tWTR(&table);
|
||||
configValues.values[KipConfigValue_low_t8_tREFI] = cust_get_low_tREFI(&table);
|
||||
configValues.values[KipConfigValue_t2_tRP_cap] = cust_get_tRP_cap(&table);
|
||||
|
||||
configValues.values[KipConfigValue_read_latency_1333] = cust_get_read_latency_1333(&table);
|
||||
configValues.values[KipConfigValue_read_latency_1600] = cust_get_read_latency_1600(&table);
|
||||
|
||||
@@ -54,8 +54,6 @@ namespace kip {
|
||||
u32 t7_tWTR;
|
||||
u32 t8_tREFI;
|
||||
|
||||
u32 t2_tRP_cap;
|
||||
|
||||
u32 timingEmcTbreak;
|
||||
u32 low_t1_tRCD;
|
||||
u32 low_t2_tRP;
|
||||
@@ -269,9 +267,6 @@ namespace kip {
|
||||
static inline bool cust_set_tREFI(const char *p, u32 v) {
|
||||
CUST_WRITE_FIELD(p, t8_tREFI, v);
|
||||
}
|
||||
static inline bool cust_set_tRP_cap(const char *p, u32 v) {
|
||||
CUST_WRITE_FIELD(p, t2_tRP_cap, v);
|
||||
}
|
||||
static inline bool cust_set_timing_emc_tbreak(const char *p, u32 v) {
|
||||
CUST_WRITE_FIELD(p, timingEmcTbreak, v);
|
||||
}
|
||||
@@ -484,9 +479,6 @@ namespace kip {
|
||||
static inline u32 cust_get_tREFI(const CustomizeTable *t) {
|
||||
return CUST_GET_FIELD(t, t8_tREFI);
|
||||
}
|
||||
static inline u32 cust_get_tRP_cap(const CustomizeTable *t) {
|
||||
return CUST_GET_FIELD(t, t2_tRP_cap);
|
||||
}
|
||||
static inline u32 cust_get_timing_emc_tbreak(const CustomizeTable *t) {
|
||||
return CUST_GET_FIELD(t, timingEmcTbreak);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user