Merge upstream Atmosphere-NX/Atmosphere master

Replace user-visible strings only, leaving firmware checks and menus unchanged.

libraries/libstratosphere/include/stratosphere/fs/common/fs_file_storage.hpp

@@ -70,11 +70,11 @@ namespace ams::fs {
             virtual Result Read(s64 offset, void *buffer, size_t size) override;
             virtual Result Write(s64 offset, const void *buffer, size_t size) override;
             virtual Result Flush() override;
-            virtual Result GetSize(s64 *out_size) override;
             virtual Result SetSize(s64 size) override;
+            virtual Result GetSize(s64 *out_size) override;
             virtual Result OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override;
     };
-
+    
     /* ACCURATE_TO_VERSION: Unknown */
     class FileStorageBasedFileSystem : public FileStorage {
         NON_COPYABLE(FileStorageBasedFileSystem);
@@ -86,7 +86,7 @@ namespace ams::fs {
 
             Result Initialize(std::shared_ptr<fs::fsa::IFileSystem> base_file_system, const fs::Path &path, fs::OpenMode mode);
     };
-
+    
     class FileHandleStorage : public IStorage, public impl::Newable {
         private:
             static constexpr s64 InvalidSize = -1;
@@ -114,5 +114,5 @@ namespace ams::fs {
             virtual Result SetSize(s64 size) override;
             virtual Result OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override;
     };
-
+    
 }

libraries/libstratosphere/include/stratosphere/fs/fs_istorage_for_batch_read.hpp

@@ -0,0 +1,96 @@
+/*
+ * Copyright (c) Atmosphère-NX
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#pragma once
+#include <stratosphere/fs/fs_common.hpp>
+#include <stratosphere/fs/fs_file.hpp>
+#include <stratosphere/fs/fs_istorage.hpp>
+#include <stratosphere/fs/fs_operate_range.hpp>
+
+namespace ams::fs {
+
+    class IStorageForBatchRead : public IStorage {
+        public:
+            virtual ~IStorageForBatchRead() { /* ... */ }
+            
+            virtual Result BatchRead(void *out0, void *out1, void *out2, void *out3, void *out4, void *out5, void *out6, const void *in) = 0;
+    };
+
+    class ReadOnlyStorageAdapterForBatchRead : public IStorageForBatchRead {
+        private:
+            std::shared_ptr<IStorageForBatchRead> m_shared_storage;
+            std::unique_ptr<IStorageForBatchRead> m_unique_storage;
+            IStorageForBatchRead *m_storage;
+        public:
+            explicit ReadOnlyStorageAdapterForBatchRead(IStorageForBatchRead *s) : m_unique_storage(s) {
+                m_storage = m_unique_storage.get();
+            }
+            explicit ReadOnlyStorageAdapterForBatchRead(std::shared_ptr<IStorageForBatchRead> s) : m_shared_storage(s) {
+                m_storage = m_shared_storage.get();
+            }
+            explicit ReadOnlyStorageAdapterForBatchRead(std::unique_ptr<IStorageForBatchRead> s) : m_unique_storage(std::move(s)) {
+                m_storage = m_unique_storage.get();
+            }
+            explicit ReadOnlyStorageAdapterForBatchRead(IStorage *s) : m_unique_storage(static_cast<IStorageForBatchRead *>(s)) {
+                m_storage = m_unique_storage.get();
+            }
+            explicit ReadOnlyStorageAdapterForBatchRead(std::shared_ptr<IStorage> s) : m_shared_storage(std::static_pointer_cast<IStorageForBatchRead>(s)) {
+                m_storage = m_shared_storage.get();
+            }
+            explicit ReadOnlyStorageAdapterForBatchRead(std::unique_ptr<IStorage> s) : m_unique_storage(std::unique_ptr<IStorageForBatchRead>(static_cast<IStorageForBatchRead *>(s.release()))) {
+                m_storage = m_unique_storage.get();
+            }
+
+            virtual ~ReadOnlyStorageAdapterForBatchRead() { /* ... */ }
+        public:
+            virtual Result Read(s64 offset, void *buffer, size_t size) override {
+                R_RETURN(m_storage->Read(offset, buffer, size));
+            }
+            
+            virtual Result Write(s64 offset, const void *buffer, size_t size) override {
+                /* TODO: Better result? Is it possible to get a more specific one? */
+                AMS_UNUSED(offset, buffer, size);
+                R_THROW(fs::ResultUnsupportedOperation());
+            }
+
+            virtual Result Flush() override {
+                R_RETURN(m_storage->Flush());
+            }
+            
+            virtual Result SetSize(s64 size) override {
+                /* TODO: Better result? Is it possible to get a more specific one? */
+                AMS_UNUSED(size);
+                R_THROW(fs::ResultUnsupportedOperation());
+            }
+            
+            virtual Result GetSize(s64 *out) override {
+                R_RETURN(m_storage->GetSize(out));
+            }
+
+            virtual Result OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override {
+                R_RETURN(m_storage->OperateRange(dst, dst_size, op_id, offset, size, src, src_size));
+            }
+            
+            virtual Result BatchRead(void *out0, void *out1, void *out2, void *out3, void *out4, void *out5, void *out6, const void *in) override {
+                /* TODO */
+                AMS_UNUSED(out0, out1, out2, out3, out4, out5, out6, in);
+                R_THROW(fs::ResultUnsupportedOperation());
+            }
+    };
+
+    template<typename T>
+    concept PointerToStorageForBatchRead = ::ams::util::RawOrSmartPointerTo<T, ::ams::fs::IStorageForBatchRead>;
+
+}

libraries/libstratosphere/include/stratosphere/fs/fs_remote_storage.hpp

@@ -16,6 +16,7 @@
 #pragma once
 #include <stratosphere/fs/fs_common.hpp>
 #include <stratosphere/fs/fs_istorage.hpp>
+#include <stratosphere/fs/fs_istorage_for_batch_read.hpp>
 #include <stratosphere/fs/impl/fs_newable.hpp>
 
 namespace ams::fs {
@@ -33,29 +34,72 @@ namespace ams::fs {
         public:
             virtual Result Read(s64 offset, void *buffer, size_t size) override {
                 R_RETURN(fsStorageRead(std::addressof(m_base_storage), offset, buffer, size));
-            };
+            }
 
             virtual Result Write(s64 offset, const void *buffer, size_t size) override {
                 R_RETURN(fsStorageWrite(std::addressof(m_base_storage), offset, buffer, size));
-            };
+            }
 
             virtual Result Flush() override {
                 R_RETURN(fsStorageFlush(std::addressof(m_base_storage)));
-            };
+            }
+            
+            virtual Result SetSize(s64 size) override {
+                R_RETURN(fsStorageSetSize(std::addressof(m_base_storage), size));
+            }
 
             virtual Result GetSize(s64 *out_size) override {
                 R_RETURN(fsStorageGetSize(std::addressof(m_base_storage), out_size));
-            };
-
-            virtual Result SetSize(s64 size) override {
-                R_RETURN(fsStorageSetSize(std::addressof(m_base_storage), size));
-            };
+            }
 
             virtual Result OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override {
                 /* TODO: How to deal with this? */
                 AMS_UNUSED(dst, dst_size, op_id, offset, size, src, src_size);
                 R_THROW(fs::ResultUnsupportedOperation());
-            };
+            }
+    };
+    
+    class RemoteStorageForBatchRead : public IStorageForBatchRead, public impl::Newable {
+        NON_COPYABLE(RemoteStorageForBatchRead);
+        NON_MOVEABLE(RemoteStorageForBatchRead);
+        private:
+            ::FsStorageForBatchRead m_base_storage;
+        public:
+            RemoteStorageForBatchRead(::FsStorageForBatchRead &s) : m_base_storage(s) { /* ... */}
+
+            virtual ~RemoteStorageForBatchRead() { fsStorageForBatchReadClose(std::addressof(m_base_storage)); }
+        public:
+            virtual Result Read(s64 offset, void *buffer, size_t size) override {
+                R_RETURN(fsStorageForBatchReadRead(std::addressof(m_base_storage), offset, buffer, size));
+            }
+
+            virtual Result Write(s64 offset, const void *buffer, size_t size) override {
+                R_RETURN(fsStorageForBatchReadWrite(std::addressof(m_base_storage), offset, buffer, size));
+            }
+
+            virtual Result Flush() override {
+                R_RETURN(fsStorageForBatchReadFlush(std::addressof(m_base_storage)));
+            }
+            
+            virtual Result SetSize(s64 size) override {
+                R_RETURN(fsStorageForBatchReadSetSize(std::addressof(m_base_storage), size));
+            }
+
+            virtual Result GetSize(s64 *out_size) override {
+                R_RETURN(fsStorageForBatchReadGetSize(std::addressof(m_base_storage), out_size));
+            }
+            
+            virtual Result OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override {
+                /* TODO: How to deal with this? */
+                AMS_UNUSED(dst, dst_size, op_id, offset, size, src, src_size);
+                R_THROW(fs::ResultUnsupportedOperation());
+            }
+            
+            virtual Result BatchRead(void *out0, void *out1, void *out2, void *out3, void *out4, void *out5, void *out6, const void *in) override {
+                /* TODO */
+                AMS_UNUSED(out0, out1, out2, out3, out4, out5, out6, in);
+                R_THROW(fs::ResultUnsupportedOperation());
+            }
     };
     #endif
 

libraries/libstratosphere/include/stratosphere/fs/impl/fs_storage_service_object_adapter.hpp

@@ -16,6 +16,7 @@
 #pragma once
 #include <stratosphere/fs/fs_common.hpp>
 #include <stratosphere/fs/fs_istorage.hpp>
+#include <stratosphere/fs/fs_istorage_for_batch_read.hpp>
 #include <stratosphere/fs/impl/fs_newable.hpp>
 
 namespace ams::fs::impl {
@@ -33,22 +34,22 @@ namespace ams::fs::impl {
             virtual Result Read(s64 offset, void *buffer, size_t size) override final {
                 R_RETURN(m_x->Read(offset, sf::OutNonSecureBuffer(buffer, size), static_cast<s64>(size)));
             }
-
-            virtual Result GetSize(s64 *out) override final {
-                R_RETURN(m_x->GetSize(out));
-            }
-
-            virtual Result Flush() override final {
-                R_RETURN(m_x->Flush());
-            }
-
+            
             virtual Result Write(s64 offset, const void *buffer, size_t size) override final {
                 R_RETURN(m_x->Write(offset, sf::InNonSecureBuffer(buffer, size), static_cast<s64>(size)));
             }
-
+            
+            virtual Result Flush() override final {
+                R_RETURN(m_x->Flush());
+            }
+            
             virtual Result SetSize(s64 size) override final {
                 R_RETURN(m_x->SetSize(size));
             }
+            
+            virtual Result GetSize(s64 *out) override final {
+                R_RETURN(m_x->GetSize(out));
+            }
 
             virtual Result OperateRange(void *dst, size_t dst_size, fs::OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override final {
                 AMS_UNUSED(src, src_size);
@@ -72,5 +73,64 @@ namespace ams::fs::impl {
                 }
             }
     };
+    
+    template<typename StorageInterfaceForBatchRead>
+    class StorageServiceObjectAdapterForBatchRead : public ::ams::fs::impl::Newable, public ::ams::fs::IStorageForBatchRead {
+        NON_COPYABLE(StorageServiceObjectAdapterForBatchRead);
+        NON_MOVEABLE(StorageServiceObjectAdapterForBatchRead);
+        private:
+            sf::SharedPointer<StorageInterfaceForBatchRead> m_x;
+        public:
+            explicit StorageServiceObjectAdapterForBatchRead(sf::SharedPointer<StorageInterfaceForBatchRead> &&o) : m_x(o) { /* ... */}
+            virtual ~StorageServiceObjectAdapterForBatchRead() { /* ... */ }
+        public:
+            virtual Result Read(s64 offset, void *buffer, size_t size) override final {
+                R_RETURN(m_x->Read(offset, sf::OutNonSecureBuffer(buffer, size), static_cast<s64>(size)));
+            }
+            
+            virtual Result Write(s64 offset, const void *buffer, size_t size) override final {
+                R_RETURN(m_x->Write(offset, sf::InNonSecureBuffer(buffer, size), static_cast<s64>(size)));
+            }
+            
+            virtual Result Flush() override final {
+                R_RETURN(m_x->Flush());
+            }
+            
+            virtual Result SetSize(s64 size) override final {
+                R_RETURN(m_x->SetSize(size));
+            }
+            
+            virtual Result GetSize(s64 *out) override final {
+                R_RETURN(m_x->GetSize(out));
+            }
+
+            virtual Result OperateRange(void *dst, size_t dst_size, fs::OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override final {
+                AMS_UNUSED(src, src_size);
+                switch (op_id) {
+                    case OperationId::Invalidate:
+                        {
+                            fs::QueryRangeInfo dummy_range_info;
+                            R_RETURN(m_x->OperateRange(std::addressof(dummy_range_info), static_cast<s32>(op_id), offset, size));
+                        }
+                    case OperationId::QueryRange:
+                        {
+                            R_UNLESS(dst != nullptr,                         fs::ResultNullptrArgument());
+                            R_UNLESS(dst_size == sizeof(fs::QueryRangeInfo), fs::ResultInvalidSize());
+
+                            R_RETURN(m_x->OperateRange(reinterpret_cast<fs::QueryRangeInfo *>(dst), static_cast<s32>(op_id), offset, size));
+                        }
+                    default:
+                        {
+                            R_THROW(fs::ResultUnsupportedOperateRangeForStorageServiceObjectAdapter());
+                        }
+                }
+            }
+            
+            virtual Result BatchRead(void *out0, void *out1, void *out2, void *out3, void *out4, void *out5, void *out6, const void *in) override final {
+                /* TODO */
+                AMS_UNUSED(out0, out1, out2, out3, out4, out5, out6, in);
+                R_THROW(fs::ResultUnsupportedOperation());
+            }
+    };
 
 }

libraries/libstratosphere/include/stratosphere/fssrv/interface_adapters/fssrv_storage_interface_adapter.hpp

@@ -18,10 +18,12 @@
 #include <stratosphere/fs/fs_query_range.hpp>
 #include <stratosphere/fssystem/fssystem_utility.hpp>
 #include <stratosphere/fssrv/sf/fssrv_sf_istorage.hpp>
+#include <stratosphere/fssrv/sf/fssrv_sf_istorage_for_batch_read.hpp>
 
 namespace ams::fs {
 
     class IStorage;
+    class IStorageForBatchRead;
 
 }
 
@@ -44,6 +46,16 @@ namespace ams::fssrv::impl {
             Result OperateRange(ams::sf::Out<fs::StorageQueryRangeInfo> out, s32 op_id, s64 offset, s64 size);
     };
     static_assert(fssrv::sf::IsIStorage<StorageInterfaceAdapter>);
+    
+    class StorageInterfaceAdapterForBatchRead : public StorageInterfaceAdapter {
+        NON_COPYABLE(StorageInterfaceAdapterForBatchRead);
+        public:
+            explicit StorageInterfaceAdapterForBatchRead(std::shared_ptr<fs::IStorageForBatchRead> &&storage) : StorageInterfaceAdapter(storage) { /* ... */ }
+        public:
+            /* Command API. */
+            Result BatchRead(const ams::sf::OutNonSecureBuffer &out0, const ams::sf::OutNonSecureBuffer &out1, const ams::sf::OutNonSecureBuffer &out2, const ams::sf::OutNonSecureBuffer &out3, const ams::sf::OutNonSecureBuffer &out4, const ams::sf::OutNonSecureBuffer &out5, const ams::sf::OutNonSecureBuffer &out6, const ams::sf::InBuffer &in);
+    };
+    static_assert(fssrv::sf::IsIStorageForBatchRead<StorageInterfaceAdapterForBatchRead>);
 
     #if defined(ATMOSPHERE_OS_HORIZON)
     class RemoteStorage {
@@ -82,6 +94,47 @@ namespace ams::fssrv::impl {
             }
     };
     static_assert(fssrv::sf::IsIStorage<RemoteStorage>);
+    
+    class RemoteStorageForBatchRead {
+        NON_COPYABLE(RemoteStorageForBatchRead);
+        NON_MOVEABLE(RemoteStorageForBatchRead);
+        private:
+            ::FsStorageForBatchRead m_base_storage;
+        public:
+            RemoteStorageForBatchRead(::FsStorageForBatchRead &s) : m_base_storage(s) { /* ... */}
+
+            virtual ~RemoteStorageForBatchRead() { fsStorageForBatchReadClose(std::addressof(m_base_storage)); }
+        public:
+            Result Read(s64 offset, const ams::sf::OutNonSecureBuffer &buffer, s64 size) {
+                R_RETURN(fsStorageForBatchReadRead(std::addressof(m_base_storage), offset, buffer.GetPointer(), size));
+            }
+
+            Result Write(s64 offset, const ams::sf::InNonSecureBuffer &buffer, s64 size) {
+                R_RETURN(fsStorageForBatchReadWrite(std::addressof(m_base_storage), offset, buffer.GetPointer(), size));
+            }
+
+            Result Flush(){
+                R_RETURN(fsStorageForBatchReadFlush(std::addressof(m_base_storage)));
+            }
+
+            Result SetSize(s64 size) {
+                R_RETURN(fsStorageForBatchReadSetSize(std::addressof(m_base_storage), size));
+            }
+
+            Result GetSize(ams::sf::Out<s64> out) {
+                R_RETURN(fsStorageForBatchReadGetSize(std::addressof(m_base_storage), out.GetPointer()));
+            }
+
+            Result OperateRange(ams::sf::Out<fs::StorageQueryRangeInfo> out, s32 op_id, s64 offset, s64 size) {
+                static_assert(sizeof(::FsRangeInfo) == sizeof(fs::StorageQueryRangeInfo));
+                R_RETURN(fsStorageForBatchReadOperateRange(std::addressof(m_base_storage), static_cast<::FsOperationId>(op_id), offset, size, reinterpret_cast<::FsRangeInfo *>(out.GetPointer())));
+            }
+            
+            Result BatchRead(const ams::sf::OutNonSecureBuffer &out0, const ams::sf::OutNonSecureBuffer &out1, const ams::sf::OutNonSecureBuffer &out2, const ams::sf::OutNonSecureBuffer &out3, const ams::sf::OutNonSecureBuffer &out4, const ams::sf::OutNonSecureBuffer &out5, const ams::sf::OutNonSecureBuffer &out6, const ams::sf::InBuffer &in) {
+                R_RETURN(fsStorageForBatchReadBatchRead(std::addressof(m_base_storage), out0.GetPointer(), out1.GetPointer(), out2.GetPointer(), out3.GetPointer(), out4.GetPointer(), out5.GetPointer(), out6.GetPointer(), in.GetPointer()));
+            }
+    };
+    static_assert(fssrv::sf::IsIStorageForBatchRead<RemoteStorageForBatchRead>);
     #endif
 
 }

libraries/libstratosphere/include/stratosphere/fssrv/sf/fssrv_sf_istorage_for_batch_read.hpp

@@ -0,0 +1,31 @@
+/*
+ * Copyright (c) Atmosphère-NX
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#pragma once
+#include <vapours.hpp>
+#include <stratosphere/sf.hpp>
+#include <stratosphere/fs/fs_file.hpp>
+#include <stratosphere/fs/fs_query_range.hpp>
+
+#define AMS_FSSRV_I_STORAGE_FOR_BATCH_READ_INTERFACE_INFO(C, H)                                                                                                                                                                                                                                                                                                                                                                      \
+    AMS_SF_METHOD_INFO(C, H, 0,  Result, Read,         (s64 offset, const ams::sf::OutNonSecureBuffer &buffer, s64 size),                                                                                                                                                                                                                                                            (offset, buffer, size))                         \
+    AMS_SF_METHOD_INFO(C, H, 1,  Result, Write,        (s64 offset, const ams::sf::InNonSecureBuffer &buffer, s64 size),                                                                                                                                                                                                                                                             (offset, buffer, size))                         \
+    AMS_SF_METHOD_INFO(C, H, 2,  Result, Flush,        (),                                                                                                                                                                                                                                                                                                                           ())                                             \
+    AMS_SF_METHOD_INFO(C, H, 3,  Result, SetSize,      (s64 size),                                                                                                                                                                                                                                                                                                                   (size))                                         \
+    AMS_SF_METHOD_INFO(C, H, 4,  Result, GetSize,      (ams::sf::Out<s64> out),                                                                                                                                                                                                                                                                                                      (out))                                          \
+    AMS_SF_METHOD_INFO(C, H, 5,  Result, OperateRange, (ams::sf::Out<ams::fs::StorageQueryRangeInfo> out, s32 op_id, s64 offset, s64 size),                                                                                                                                                                                                                                          (out, op_id, offset, size))                     \
+    AMS_SF_METHOD_INFO(C, H, 10, Result, BatchRead,    (const ams::sf::OutNonSecureBuffer &out0, const ams::sf::OutNonSecureBuffer &out1, const ams::sf::OutNonSecureBuffer &out2, const ams::sf::OutNonSecureBuffer &out3, const ams::sf::OutNonSecureBuffer &out4, const ams::sf::OutNonSecureBuffer &out5, const ams::sf::OutNonSecureBuffer &out6, const ams::sf::InBuffer &in), (out0, out1, out2, out3, out4, out5, out6, in))
+
+AMS_SF_DEFINE_INTERFACE(ams::fssrv::sf, IStorageForBatchRead, AMS_FSSRV_I_STORAGE_FOR_BATCH_READ_INTERFACE_INFO, 0xCD2D5606)

libraries/libstratosphere/include/stratosphere/socket/socket_types.hpp

@@ -158,7 +158,40 @@ namespace ams::socket {
         char *ai_canonname;
         AddrInfo *ai_next;
     };
-
+    
+    /* NOTE: We are using the c-ares structs under ams::socket. */
+    /* Should we include c-ares instead somewhere? */
+    struct ares_addrinfo_node {
+        int ai_ttl;
+        int ai_flags;
+        int ai_family;
+        int ai_socktype;
+        int ai_protocol;
+        socklen_t ai_addrlen;
+        struct sockaddr *ai_addr;
+        struct ares_addrinfo_node *ai_next;
+    };
+    
+    struct ares_addrinfo_cname {
+        int ttl;
+        char *alias;
+        char *name;
+        struct ares_addrinfo_cname *next;
+    };
+    
+    struct ares_addrinfo {
+        struct ares_addrinfo_cname *cnames;
+        struct ares_addrinfo_node  *nodes;
+        char *name;
+    };
+    
+    struct ares_addrinfo_hints {
+        int ai_flags;
+        int ai_family;
+        int ai_socktype;
+        int ai_protocol;
+    };
+    
     struct TimeVal {
         long tv_sec;
         long tv_usec;

libraries/libstratosphere/source/fs/common/fs_file_storage.cpp

@@ -58,6 +58,11 @@ namespace ams::fs {
     Result FileStorage::Flush() {
         R_RETURN(m_base_file->Flush());
     }
+    
+    Result FileStorage::SetSize(s64 size) {
+        m_size = InvalidSize;
+        R_RETURN(m_base_file->SetSize(size));
+    }
 
     Result FileStorage::GetSize(s64 *out_size) {
         R_TRY(this->UpdateSize());
@@ -65,11 +70,6 @@ namespace ams::fs {
         R_SUCCEED();
     }
 
-    Result FileStorage::SetSize(s64 size) {
-        m_size = InvalidSize;
-        R_RETURN(m_base_file->SetSize(size));
-    }
-
     Result FileStorage::OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) {
         switch (op_id) {
             case OperationId::Invalidate:
@@ -102,7 +102,7 @@ namespace ams::fs {
 
         R_SUCCEED();
     }
-
+    
     Result FileHandleStorage::UpdateSize() {
         R_SUCCEED_IF(m_size != InvalidSize);
         R_RETURN(GetFileSize(std::addressof(m_size), m_handle));
@@ -149,6 +149,11 @@ namespace ams::fs {
     Result FileHandleStorage::Flush() {
         R_RETURN(FlushFile(m_handle));
     }
+    
+    Result FileHandleStorage::SetSize(s64 size) {
+        m_size = InvalidSize;
+        R_RETURN(SetFileSize(m_handle, size));
+    }
 
     Result FileHandleStorage::GetSize(s64 *out_size) {
         R_TRY(this->UpdateSize());
@@ -156,11 +161,6 @@ namespace ams::fs {
         R_SUCCEED();
     }
 
-    Result FileHandleStorage::SetSize(s64 size) {
-        m_size = InvalidSize;
-        R_RETURN(SetFileSize(m_handle, size));
-    }
-
     Result FileHandleStorage::OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) {
         AMS_UNUSED(src, src_size);
 

libraries/libstratosphere/source/fssrv/fssrv_storage_interface_adapter.cpp

@@ -30,7 +30,7 @@ namespace ams::fssrv::impl {
         }));
     }
 
-    Result StorageInterfaceAdapter::Write(s64 offset, const ams::sf::InNonSecureBuffer &buffer, s64 size)  {
+    Result StorageInterfaceAdapter::Write(s64 offset, const ams::sf::InNonSecureBuffer &buffer, s64 size) {
         /* Check pre-conditions. */
         R_UNLESS(0 <= offset,                                fs::ResultInvalidOffset());
         R_UNLESS(0 <= size,                                  fs::ResultInvalidSize());
@@ -42,16 +42,16 @@ namespace ams::fssrv::impl {
         R_RETURN(m_base_storage->Write(offset, buffer.GetPointer(), size));
     }
 
-    Result StorageInterfaceAdapter::Flush()  {
+    Result StorageInterfaceAdapter::Flush() {
         R_RETURN(m_base_storage->Flush());
     }
 
-    Result StorageInterfaceAdapter::SetSize(s64 size)  {
+    Result StorageInterfaceAdapter::SetSize(s64 size) {
         R_UNLESS(size >= 0, fs::ResultInvalidSize());
         R_RETURN(m_base_storage->SetSize(size));
     }
 
-    Result StorageInterfaceAdapter::GetSize(ams::sf::Out<s64> out)  {
+    Result StorageInterfaceAdapter::GetSize(ams::sf::Out<s64> out) {
         R_RETURN(m_base_storage->GetSize(out.GetPointer()));
     }
 
@@ -72,5 +72,11 @@ namespace ams::fssrv::impl {
 
         R_SUCCEED();
     }
+    
+    Result StorageInterfaceAdapterForBatchRead::BatchRead(const ams::sf::OutNonSecureBuffer &out0, const ams::sf::OutNonSecureBuffer &out1, const ams::sf::OutNonSecureBuffer &out2, const ams::sf::OutNonSecureBuffer &out3, const ams::sf::OutNonSecureBuffer &out4, const ams::sf::OutNonSecureBuffer &out5, const ams::sf::OutNonSecureBuffer &out6, const ams::sf::InBuffer &in)  {
+        /* TODO */
+        AMS_UNUSED(out0, out1, out2, out3, out4, out5, out6, in);
+        R_THROW(fs::ResultUnsupportedOperation());
+    }
 
 }

libraries/libstratosphere/source/os/os_shared_memory.cpp

@@ -33,6 +33,9 @@ namespace ams::os {
 
             /* Create the critical section. */
             util::ConstructAt(shared_memory->cs_shared_memory);
+
+            /* Set state to initialized. */
+            shared_memory->state = SharedMemoryType::State_Initialized;
         }
 
     }

libraries/libstratosphere/source/os/os_transfer_memory.cpp

@@ -33,6 +33,9 @@ namespace ams::os {
 
             /* Create the critical section. */
             util::ConstructAt(tmem->cs_transfer_memory);
+
+            /* Set state to created. */
+            tmem->state = TransferMemoryType::State_Created;
         }
 
     }

stratosphere/ams_mitm/source/dns_mitm/dnsmitm_resolver_impl.cpp

@@ -21,6 +21,20 @@
 #include "sfdnsres_shim.h"
 
 namespace ams::mitm::socket::resolver {
+    
+    namespace {
+        
+        struct AresAddrInfoQuery {
+            std::string hostname;
+            ams::socket::InAddrT redirect_addr;
+            u16 redirect_port;
+            const struct ams::socket::ares_addrinfo_hints *hint;
+        };
+        
+        std::map<ssize_t, std::unique_ptr<AresAddrInfoQuery>> g_ares_addr_info_queries;
+        ssize_t g_current_ares_addr_info_query_id;
+        
+    }
 
     ssize_t SerializeRedirectedHostEnt(u8 * const dst, size_t dst_size, const char *hostname, ams::socket::InAddrT redirect_addr) {
         struct in_addr addr = { .s_addr = redirect_addr };
@@ -85,6 +99,97 @@ namespace ams::mitm::socket::resolver {
         AMS_ABORT_UNLESS(result >= 0);
         return result;
     }
+    
+    ssize_t QueueAresAddrInfoQuery(const char *hostname, ams::socket::InAddrT redirect_addr, u16 redirect_port, const struct ams::socket::ares_addrinfo_hints *hint) {              
+        ssize_t query_id = g_current_ares_addr_info_query_id;
+        
+        AresAddrInfoQuery query;
+        query.hostname = hostname;
+        query.redirect_addr = redirect_addr;
+        query.redirect_port = redirect_port;
+        query.hint = hint;
+
+        g_ares_addr_info_queries.emplace(query_id, std::make_unique<AresAddrInfoQuery>(query));
+        
+        /* NOTE: This really just increases ad infinitum. Should we bother checking it? */
+        ++g_current_ares_addr_info_query_id;
+        
+        return query_id;
+    }
+    
+    ssize_t DequeueAresAddrInfoQuery(u8 * const dst, size_t dst_size, u32 query_id) {
+        AresAddrInfoQuery *query = nullptr;
+        
+        for (auto it = g_ares_addr_info_queries.begin(); it != g_ares_addr_info_queries.end(); ++it) {
+            if (it->first == static_cast<ssize_t>(query_id)) {
+                query = it->second.get();
+                break;
+            }
+        }
+        
+        if (query == nullptr) {
+            return 0;
+        }
+        
+        struct ams::socket::ares_addrinfo_node node = {
+            .ai_ttl      = 0,
+            .ai_flags    = AF_UNSPEC,
+            .ai_family   = 0,
+            .ai_socktype = 0,
+            .ai_protocol = 0,
+            .ai_addrlen  = 0,
+            .ai_next     = nullptr,
+        };
+        
+        if (query->hint != nullptr) {
+            std::memcpy(reinterpret_cast<void *>(std::addressof(node.ai_flags)), reinterpret_cast<const void *>(query->hint), sizeof(struct ams::socket::ares_addrinfo_hints));
+        }
+
+        switch (node.ai_family) {
+            case AF_UNSPEC: node.ai_family = AF_INET; break;
+            case AF_INET:   node.ai_family = AF_INET; break;
+            case AF_INET6:  AMS_ABORT("Redirected INET6 not supported"); break;
+            AMS_UNREACHABLE_DEFAULT_CASE();
+        }
+
+        if (node.ai_socktype == 0) {
+            node.ai_socktype = SOCK_STREAM;
+        }
+
+        if (node.ai_protocol == 0) {
+            node.ai_protocol = IPPROTO_TCP;
+        }
+
+        const struct sockaddr_in sin = {
+            .sin_family = AF_INET,
+            .sin_port   = ams::socket::InetHtons(query->redirect_port),
+            .sin_addr   = { .s_addr = query->redirect_addr },
+            .sin_zero   = {},
+        };
+
+        node.ai_addrlen = sizeof(sin);
+        node.ai_addr    = (struct sockaddr *)(std::addressof(sin));
+        
+        struct ams::socket::ares_addrinfo ai {
+            .cnames = nullptr,
+            .nodes  = std::addressof(node),
+            .name   = const_cast<char *>(query->hostname.c_str()),
+        };
+
+        const auto result = serializer::DNSSerializer::ToBuffer(dst, dst_size, ai);
+        AMS_ABORT_UNLESS(result >= 0);
+        g_ares_addr_info_queries.erase(query_id);
+        return result;
+    }
+    
+    void CancelAresAddrInfoQuery(u32 query_id) {
+        for (auto it = g_ares_addr_info_queries.begin(); it != g_ares_addr_info_queries.end(); ++it) {
+            if (it->first == static_cast<ssize_t>(query_id)) {
+                g_ares_addr_info_queries.erase(it);
+                break;
+            }
+        }
+    }
 
     Result ResolverImpl::GetHostByNameRequest(u32 cancel_handle, const sf::ClientProcessId &client_pid, bool use_nsd_resolve, const sf::InBuffer &name, sf::Out<u32> out_host_error, sf::Out<u32> out_errno, const sf::OutBuffer &out_hostent, sf::Out<u32> out_size) {
         AMS_UNUSED(cancel_handle, client_pid, use_nsd_resolve);
@@ -208,6 +313,83 @@ namespace ams::mitm::socket::resolver {
 
         R_SUCCEED();
     }
+    
+    Result ResolverImpl::ReportTelemetry(const sf::ClientProcessId &client_pid, const sf::InBuffer &telemetry, u32 version) {
+        /* NOTE: As of 23.0.0 this command does nothing. We mitm it anyway for future proofing. */
+        AMS_UNUSED(client_pid, telemetry, version);
+        R_SUCCEED();
+    }
+    
+    Result ResolverImpl::QueryAddrInfoRequestWithOptions(const sf::ClientProcessId &client_pid, const sf::InAutoSelectBuffer &node, const sf::InAutoSelectBuffer &srv, const sf::InAutoSelectBuffer &serialized_hint, sf::Out<u32> out_query_id, u32 fd, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_retval, sf::Out<s32> out_errno) {
+        AMS_UNUSED(client_pid, fd, options_version, options, num_options);
+
+        const char *hostname = reinterpret_cast<const char *>(node.GetPointer());
+
+        LogDebug("[%016lx]: QueryAddrInfoRequestWithOptions(%s, %s)\n", m_client_info.program_id.value, hostname, reinterpret_cast<const char *>(srv.GetPointer()));
+
+        R_UNLESS(hostname != nullptr, sm::mitm::ResultShouldForwardToSession());
+
+        ams::socket::InAddrT redirect_addr = {};
+        R_UNLESS(GetRedirectedHostByName(std::addressof(redirect_addr), hostname), sm::mitm::ResultShouldForwardToSession());
+
+        u16 port = 0;
+        if (srv.GetPointer() != nullptr) {
+            for (const char *cur = reinterpret_cast<const char *>(srv.GetPointer()); *cur != 0; ++cur) {
+                AMS_ABORT_UNLESS(std::isdigit(static_cast<unsigned char>(*cur)));
+                port *= 10;
+                port += *cur - '0';
+            }
+        }
+
+        LogDebug("[%016lx]: Queueing redirection %s:%u to %u.%u.%u.%u\n", m_client_info.program_id.value, hostname, port, (redirect_addr >> 0) & 0xFF, (redirect_addr >> 8) & 0xFF, (redirect_addr >> 16) & 0xFF, (redirect_addr >> 24) & 0xFF);
+        
+        const bool use_hint = serialized_hint.GetPointer() != nullptr;
+        struct ams::socket::ares_addrinfo_hints hint = {};
+        if (use_hint) {
+            AMS_ABORT_UNLESS(serializer::DNSSerializer::FromBuffer(hint, serialized_hint.GetPointer(), serialized_hint.GetSize()) >= 0);
+        }
+        
+        const auto query_id = QueueAresAddrInfoQuery(hostname, redirect_addr, port, use_hint ? std::addressof(hint) : nullptr);
+        
+        LogDebug("[%016lx]: Queued query with id 0x%lx\n", m_client_info.program_id.value, query_id);
+        
+        /* Forward the query. The provided socket EventFd must be signalled by having bsdsocket write 1 to the associated socket. */
+        /* This is fine though, we only care about replacing with our redirection during fetch. */        
+        R_TRY(sfdnsresQueryAddrInfoRequestWithOptionsFwd(m_forward_service.get(), static_cast<u64>(client_pid.GetValue().value), node.GetPointer(), node.GetSize(), srv.GetPointer(), srv.GetSize(), serialized_hint.GetPointer(), serialized_hint.GetSize(), reinterpret_cast<u32 *>(out_query_id.GetPointer()), fd, options_version, options.GetPointer(), options.GetSize(), num_options, reinterpret_cast<s32 *>(out_retval.GetPointer()), reinterpret_cast<s32 *>(out_errno.GetPointer())));
+        
+        /* Replace with our own query. */
+        *out_query_id    = query_id;
+        *out_retval      = 0;
+        *out_errno       = 0;
+        
+        R_SUCCEED();
+    }
+    
+    Result ResolverImpl::FetchAddrInfoRequestWithOptions(const sf::ClientProcessId &client_pid, u32 query_id, u32 version, const sf::OutAutoSelectBuffer &out_addrinfo, sf::Out<u32> out_size, sf::Out<s32> out_retval, sf::Out<s32> out_errno) {
+        AMS_UNUSED(client_pid, version);
+
+        LogDebug("[%016lx]: FetchAddrInfoRequestWithOptions(%d)\n", m_client_info.program_id.value, query_id);
+        
+        const auto size = DequeueAresAddrInfoQuery(out_addrinfo.GetPointer(), out_addrinfo.GetSize(), query_id);
+        
+        LogDebug("[%016lx]: Dequeued query with size 0x%lx\n", m_client_info.program_id.value, size);
+        
+        *out_size        = size;
+        *out_retval      = 0;
+        *out_errno       = 0;
+
+        R_SUCCEED();
+    }
+    
+    Result ResolverImpl::CancelQuery(const sf::ClientProcessId &client_pid, u32 query_id) {
+        AMS_UNUSED(client_pid);
+
+        LogDebug("[%016lx]: CancelQuery(%d)\n", m_client_info.program_id.value, query_id);
+        
+        CancelAresAddrInfoQuery(query_id);
+
+        R_SUCCEED();
+    }
 
     Result ResolverImpl::AtmosphereReloadHostsFile() {
         /* Perform a hosts file reload. */

stratosphere/ams_mitm/source/dns_mitm/dnsmitm_resolver_impl.hpp

@@ -16,11 +16,15 @@
 #pragma once
 #include <stratosphere.hpp>
 
-#define AMS_DNS_MITM_INTERFACE_INFO(C, H)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        \
-    AMS_SF_METHOD_INFO(C, H,     2, Result, GetHostByNameRequest,            (u32 cancel_handle, const sf::ClientProcessId &client_pid, bool use_nsd_resolve, const sf::InBuffer &name, sf::Out<u32> out_host_error, sf::Out<u32> out_errno, const sf::OutBuffer &out_hostent, sf::Out<u32> out_size),                                                                                                                                       (cancel_handle, client_pid, use_nsd_resolve, name, out_host_error, out_errno, out_hostent, out_size))                                                               \
-    AMS_SF_METHOD_INFO(C, H,     6, Result, GetAddrInfoRequest,              (u32 cancel_handle, const sf::ClientProcessId &client_pid, bool use_nsd_resolve, const sf::InBuffer &node, const sf::InBuffer &srv, const sf::InBuffer &serialized_hint, const sf::OutBuffer &out_addrinfo, sf::Out<u32> out_errno, sf::Out<s32> out_retval, sf::Out<u32> out_size),                                                                            (cancel_handle, client_pid, use_nsd_resolve, node, srv, serialized_hint, out_addrinfo, out_errno, out_retval, out_size))                                            \
-    AMS_SF_METHOD_INFO(C, H,    10, Result, GetHostByNameRequestWithOptions, (const sf::ClientProcessId &client_pid, const sf::InAutoSelectBuffer &name, const sf::OutAutoSelectBuffer &out_hostent, sf::Out<u32> out_size, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_host_error, sf::Out<s32> out_errno),                                                                               (client_pid, name, out_hostent, out_size, options_version, options, num_options, out_host_error, out_errno),                                    hos::Version_5_0_0) \
-    AMS_SF_METHOD_INFO(C, H,    12, Result, GetAddrInfoRequestWithOptions,   (const sf::ClientProcessId &client_pid, const sf::InBuffer &node, const sf::InBuffer &srv, const sf::InBuffer &serialized_hint, const sf::OutAutoSelectBuffer &out_addrinfo, sf::Out<u32> out_size, sf::Out<s32> out_retval, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_host_error, sf::Out<s32> out_errno), (client_pid, node, srv, serialized_hint, out_addrinfo, out_size, out_retval, options_version, options, num_options, out_host_error, out_errno), hos::Version_5_0_0) \
+#define AMS_DNS_MITM_INTERFACE_INFO(C, H)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         \
+    AMS_SF_METHOD_INFO(C, H,     2, Result, GetHostByNameRequest,            (u32 cancel_handle, const sf::ClientProcessId &client_pid, bool use_nsd_resolve, const sf::InBuffer &name, sf::Out<u32> out_host_error, sf::Out<u32> out_errno, const sf::OutBuffer &out_hostent, sf::Out<u32> out_size),                                                                                                                                       (cancel_handle, client_pid, use_nsd_resolve, name, out_host_error, out_errno, out_hostent, out_size))                                                                \
+    AMS_SF_METHOD_INFO(C, H,     6, Result, GetAddrInfoRequest,              (u32 cancel_handle, const sf::ClientProcessId &client_pid, bool use_nsd_resolve, const sf::InBuffer &node, const sf::InBuffer &srv, const sf::InBuffer &serialized_hint, const sf::OutBuffer &out_addrinfo, sf::Out<u32> out_errno, sf::Out<s32> out_retval, sf::Out<u32> out_size),                                                                            (cancel_handle, client_pid, use_nsd_resolve, node, srv, serialized_hint, out_addrinfo, out_errno, out_retval, out_size))                                             \
+    AMS_SF_METHOD_INFO(C, H,    10, Result, GetHostByNameRequestWithOptions, (const sf::ClientProcessId &client_pid, const sf::InAutoSelectBuffer &name, const sf::OutAutoSelectBuffer &out_hostent, sf::Out<u32> out_size, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_host_error, sf::Out<s32> out_errno),                                                                               (client_pid, name, out_hostent, out_size, options_version, options, num_options, out_host_error, out_errno),                                    hos::Version_5_0_0)  \
+    AMS_SF_METHOD_INFO(C, H,    12, Result, GetAddrInfoRequestWithOptions,   (const sf::ClientProcessId &client_pid, const sf::InBuffer &node, const sf::InBuffer &srv, const sf::InBuffer &serialized_hint, const sf::OutAutoSelectBuffer &out_addrinfo, sf::Out<u32> out_size, sf::Out<s32> out_retval, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_host_error, sf::Out<s32> out_errno), (client_pid, node, srv, serialized_hint, out_addrinfo, out_size, out_retval, options_version, options, num_options, out_host_error, out_errno), hos::Version_5_0_0)  \
+    AMS_SF_METHOD_INFO(C, H,    16, Result, ReportTelemetry,                 (const sf::ClientProcessId &client_pid, const sf::InBuffer &telemetry, u32 version),                                                                                                                                                                                                                                                                            (client_pid, telemetry, version),                                                                                                               hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H,   100, Result, QueryAddrInfoRequestWithOptions, (const sf::ClientProcessId &client_pid, const sf::InAutoSelectBuffer &node, const sf::InAutoSelectBuffer &srv, const sf::InAutoSelectBuffer &serialized_hint, sf::Out<u32> out_query_id, u32 fd, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_retval, sf::Out<s32> out_errno),                                 (client_pid, node, srv, serialized_hint, out_query_id, fd, options_version, options, num_options, out_retval, out_errno),                       hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H,   102, Result, FetchAddrInfoRequestWithOptions, (const sf::ClientProcessId &client_pid, u32 query_id, u32 version, const sf::OutAutoSelectBuffer &out_addrinfo, sf::Out<u32> out_size, sf::Out<s32> out_retval, sf::Out<s32> out_errno),                                                                                                                                                                        (client_pid, query_id, version, out_addrinfo, out_size, out_retval, out_errno),                                                                 hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H,   104, Result, CancelQuery,                     (const sf::ClientProcessId &client_pid, u32 query_id),                                                                                                                                                                                                                                                                                                          (client_pid, query_id),                                                                                                                         hos::Version_23_0_0) \
     AMS_SF_METHOD_INFO(C, H, 65000, Result, AtmosphereReloadHostsFile,       (),                                                                                                                                                                                                                                                                                                                                                             ())
 
 AMS_SF_DEFINE_MITM_INTERFACE(ams::mitm::socket::resolver, IResolver, AMS_DNS_MITM_INTERFACE_INFO, 0x5935F91A)
@@ -44,7 +48,11 @@ namespace ams::mitm::socket::resolver {
             Result GetAddrInfoRequest(u32 cancel_handle, const sf::ClientProcessId &client_pid, bool use_nsd_resolve, const sf::InBuffer &node, const sf::InBuffer &srv, const sf::InBuffer &serialized_hint, const sf::OutBuffer &out_addrinfo, sf::Out<u32> out_errno, sf::Out<s32> out_retval, sf::Out<u32> out_size);
             Result GetHostByNameRequestWithOptions(const sf::ClientProcessId &client_pid, const sf::InAutoSelectBuffer &name, const sf::OutAutoSelectBuffer &out_hostent, sf::Out<u32> out_size, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_host_error, sf::Out<s32> out_errno);
             Result GetAddrInfoRequestWithOptions(const sf::ClientProcessId &client_pid, const sf::InBuffer &node, const sf::InBuffer &srv, const sf::InBuffer &serialized_hint, const sf::OutAutoSelectBuffer &out_addrinfo, sf::Out<u32> out_size, sf::Out<s32> out_retval, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_host_error, sf::Out<s32> out_errno);
-
+            Result ReportTelemetry(const sf::ClientProcessId &client_pid, const sf::InBuffer &telemetry, u32 version);
+            Result QueryAddrInfoRequestWithOptions(const sf::ClientProcessId &client_pid, const sf::InAutoSelectBuffer &node, const sf::InAutoSelectBuffer &srv, const sf::InAutoSelectBuffer &serialized_hint, sf::Out<u32> out_query_id, u32 fd, u32 options_version, const sf::InAutoSelectBuffer &options, u32 num_options, sf::Out<s32> out_retval, sf::Out<s32> out_errno);
+            Result FetchAddrInfoRequestWithOptions(const sf::ClientProcessId &client_pid, u32 query_id, u32 version, const sf::OutAutoSelectBuffer &out_addrinfo, sf::Out<u32> out_size, sf::Out<s32> out_retval, sf::Out<s32> out_errno);
+            Result CancelQuery(const sf::ClientProcessId &client_pid, u32 query_id);
+            
             /* Extension commands. */
             Result AtmosphereReloadHostsFile();
     };

stratosphere/ams_mitm/source/dns_mitm/serializer/serializer_impls_addrinfo.cpp

@@ -190,14 +190,20 @@ namespace ams::mitm::socket::resolver::serializer {
                         return rc;
                     }
                 } else {
-                    if (dst_size - (cur - dst) < addr_info.ai_addrlen) {
+                    if (hos::GetVersion() >= hos::Version_23_0_0) {
+                        /* 23.0.0 fixed this by returning an error instead. */
                         rc = -1;
                         return rc;
-                    }
+                    } else {
+                        if (dst_size - (cur - dst) < addr_info.ai_addrlen) {
+                            rc = -1;
+                            return rc;
+                        }
 
-                    /* NOTE: This is clearly a nintendo bug, see the accompanying note in FromBufferInternalImpl */
-                    std::memmove(cur, std::addressof(addr_info.ai_addr), addr_info.ai_addrlen);
-                    rc = addr_info.ai_addrlen;
+                        /* NOTE: This is clearly a nintendo bug, see the accompanying note in FromBufferInternalImpl */
+                        std::memmove(cur, std::addressof(addr_info.ai_addr), addr_info.ai_addrlen);
+                        rc = addr_info.ai_addrlen;
+                    }
                 }
                 cur += rc;
             }
@@ -317,6 +323,7 @@ namespace ams::mitm::socket::resolver::serializer {
                 } else if (IsAfInet<T>(out.ai_family)) {
                     out.ai_addr = static_cast<SockAddrType<T> *>(ams::socket::impl::Alloc(sizeof(SockAddrInType<T>)));
                     if (out.ai_addr == nullptr) {
+                        ams::socket::SetLastError(ams::socket::Errno::ENoMem);
                         rc = -1;
                         return rc;
                     }
@@ -328,6 +335,7 @@ namespace ams::mitm::socket::resolver::serializer {
                 } else if (IsAfInet6<T>(out.ai_family)) {
                     out.ai_addr = static_cast<SockAddrType<T> *>(ams::socket::impl::Alloc(sizeof(SockAddrIn6Type<T>)));
                     if (out.ai_addr == nullptr) {
+                        ams::socket::SetLastError(ams::socket::Errno::ENoMem);
                         rc = -1;
                         return rc;
                     }
@@ -337,17 +345,24 @@ namespace ams::mitm::socket::resolver::serializer {
                         return rc;
                     }
                 } else {
-                    out.ai_addr = static_cast<decltype(out.ai_addr)>(ams::socket::impl::Alloc(out.ai_addrlen));
-                    if (out.ai_addr == nullptr) {
+                    if (hos::GetVersion() >= hos::Version_23_0_0) {
+                        /* 23.0.0 fixed this by returning an error instead. */
+                        ams::socket::SetLastError(ams::socket::Errno::EInval);
                         rc = -1;
                         return rc;
-                    }
+                    } else {
+                        out.ai_addr = static_cast<decltype(out.ai_addr)>(ams::socket::impl::Alloc(out.ai_addrlen));
+                        if (out.ai_addr == nullptr) {
+                            rc = -1;
+                            return rc;
+                        }
 
-                    /* NOTE: This is *clearly* a nintendo bug. */
-                    /* They obviously intend to copy to the buffer they just allocated, but instead they copy to the addrinfo structure itself. */
-                    /* Probably &out.ai_addr instead of &out.ai_addr[0]? Either way, we'll implement what they do, but... */
-                    std::memcpy(std::addressof(out.ai_addr), cur, out.ai_addrlen);
-                    rc = out.ai_addrlen;
+                        /* NOTE: This is *clearly* a nintendo bug. */
+                        /* They obviously intend to copy to the buffer they just allocated, but instead they copy to the addrinfo structure itself. */
+                        /* Probably &out.ai_addr instead of &out.ai_addr[0]? Either way, we'll implement what they do, but... */
+                        std::memcpy(std::addressof(out.ai_addr), cur, out.ai_addrlen);
+                        rc = out.ai_addrlen;
+                    }
                 }
                 cur += rc;
             }
@@ -368,6 +383,7 @@ namespace ams::mitm::socket::resolver::serializer {
                 } else if (tmp_value == AddrInfoMagic) {
                     out.ai_next = static_cast<T *>(ams::socket::impl::Alloc(sizeof(T)));
                     if (out.ai_next == nullptr) {
+                        ams::socket::SetLastError(ams::socket::Errno::ENoMem);
                         rc = -1;
                         return rc;
                     }

stratosphere/ams_mitm/source/dns_mitm/serializer/serializer_impls_ares.cpp

@@ -0,0 +1,380 @@
+/*
+ * Copyright (c) Atmosphère-NX
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#include <stratosphere.hpp>
+#include "../dnsmitm_debug.hpp"
+#include "../socket_allocator.hpp"
+#include "serializer.hpp"
+
+namespace ams::mitm::socket::resolver::serializer {
+    
+    namespace {
+        
+        /* NOTE: This is local to the nn::socket::resolver::serializer namespace. */
+        struct AddrInfoNodeCname {
+            struct ams::socket::ares_addrinfo_node *node;
+            char *ai_canonname;
+        };
+
+        constexpr inline u32 AresMagic = 0xBEEFCAFE;
+        
+        template<typename T>
+        concept IsAresAddrInfo = std::same_as<T, struct ams::socket::ares_addrinfo>;
+        
+        template<typename T>
+        concept IsAresAddrInfoHints = std::same_as<T, struct ams::socket::ares_addrinfo_hints>;
+        
+        template<typename T>
+        concept IsAresAddrInfoNode = std::same_as<T, struct ams::socket::ares_addrinfo_node>;
+        
+        template<typename T>
+        concept IsAddrInfoNodeCname = std::same_as<T, AddrInfoNodeCname>;
+
+        template<typename T> requires IsAresAddrInfoNode<T> || IsAddrInfoNodeCname<T>
+        using SockAddrInType = typename std::conditional<std::same_as<T, struct ams::socket::ares_addrinfo> || std::same_as<T, AddrInfoNodeCname>, struct sockaddr_in, struct sockaddr_in>::type;
+
+        template<typename T> requires IsAresAddrInfoNode<T> || IsAddrInfoNodeCname<T>
+        using SockAddrIn6Type = typename std::conditional<std::same_as<T, struct ams::socket::ares_addrinfo> || std::same_as<T, AddrInfoNodeCname>, struct sockaddr_in6, struct sockaddr_in6>::type;
+
+        template<typename T> requires IsAresAddrInfoNode<T> || IsAddrInfoNodeCname<T>
+        constexpr bool IsAfInet(const auto ai_family) {
+            if constexpr (std::same_as<T, struct ams::socket::ares_addrinfo_node> || std::same_as<T, AddrInfoNodeCname>) {
+                /* NOTE: Keep this in case a nn::socket::AddrInfo equivalent is ever implemented for c-ares. */
+                /* As of 23.0.0 only the ares_addrinfo struct is supported in the serializer. */
+                return ai_family == AF_INET;
+            } else {
+                return ai_family == AF_INET;
+            }
+        }
+
+        template<typename T> requires IsAresAddrInfoNode<T> || IsAddrInfoNodeCname<T>
+        constexpr bool IsAfInet6(const auto ai_family) {
+            if constexpr (std::same_as<T, struct ams::socket::ares_addrinfo_node> || std::same_as<T, AddrInfoNodeCname>) {
+                /* NOTE: Keep this in case a nn::socket::AddrInfo equivalent is ever implemented for c-ares. */
+                /* As of 23.0.0 only the ares_addrinfo struct is supported in the serializer. */
+                return ai_family == AF_INET6;
+            } else {
+                return ai_family == AF_INET6;
+            }
+        }
+
+        template<typename T> requires IsAresAddrInfoNode<T>
+        size_t AddrInfoNodeSizeOf(const T *ares_addr_info_node) {
+            size_t rc = 6 * sizeof(u32);
+
+            if (ares_addr_info_node->ai_addr == nullptr) {
+                rc += sizeof(u32);
+            } else if (IsAfInet<T>(ares_addr_info_node->ai_family)) {
+                rc += DNSSerializer::SizeOf(*reinterpret_cast<SockAddrInType<T> *>(ares_addr_info_node->ai_addr));
+            } else if (IsAfInet6<T>(ares_addr_info_node->ai_family)) {
+                rc += DNSSerializer::SizeOf(*reinterpret_cast<SockAddrIn6Type<T> *>(ares_addr_info_node->ai_addr));
+            } else if (ares_addr_info_node->ai_addrlen == 0) {
+                rc += sizeof(u32);
+            } else {
+                rc += ares_addr_info_node->ai_addrlen;
+            }
+
+            if (ares_addr_info_node->ai_next == nullptr) {
+                rc += sizeof(u32);
+            }
+
+            return rc;
+        }
+
+        template<typename T> requires IsAresAddrInfo<T>
+        size_t SizeOfImpl(const T &in) {
+            size_t rc = 0;
+            
+            const T *ares_addr_info = std::addressof(in);
+            for (const struct ams::socket::ares_addrinfo_node *ares_addr_info_node = ares_addr_info->nodes; ares_addr_info_node != nullptr; ares_addr_info_node = ares_addr_info_node->ai_next) {
+                rc += AddrInfoNodeSizeOf(ares_addr_info_node);
+            }
+
+            return rc;
+        }
+        
+        template<typename T> requires IsAresAddrInfoHints<T>
+        size_t SizeOfImpl(const T &) {
+            return 5 * sizeof(u32);
+        }
+
+        template<typename T> requires IsAddrInfoNodeCname<T>
+        ssize_t ToBufferInternalImpl(u8 * const dst, size_t dst_size, const T &addr_info_node_cname) {
+            ssize_t rc = -1;
+            u8 *cur = dst;
+
+            {
+                const u32 value = AresMagic;
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(addr_info_node_cname.node->ai_flags);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(addr_info_node_cname.node->ai_family);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(addr_info_node_cname.node->ai_socktype);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(addr_info_node_cname.node->ai_protocol);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(addr_info_node_cname.node->ai_addrlen);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                if (addr_info_node_cname.node->ai_addr == nullptr || addr_info_node_cname.node->ai_addrlen == 0) {
+                    const u32 value = 0;
+                    if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                        return rc;
+                    }
+                } else if (IsAfInet<T>(addr_info_node_cname.node->ai_family)) {
+                    if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), *reinterpret_cast<SockAddrInType<T> *>(addr_info_node_cname.node->ai_addr))) == -1) {
+                        return rc;
+                    }
+                } else if (IsAfInet6<T>(addr_info_node_cname.node->ai_family)) {
+                    if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), *reinterpret_cast<SockAddrIn6Type<T> *>(addr_info_node_cname.node->ai_addr))) == -1) {
+                        return rc;
+                    }
+                } else {
+                    rc = -1;
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), addr_info_node_cname.ai_canonname)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            if (addr_info_node_cname.node->ai_next == nullptr) {
+                const u32 value = 0;
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            rc = cur - dst;
+            return rc;
+        }
+
+        template<typename T> requires IsAresAddrInfo<T>
+        ssize_t ToBufferImpl(u8 * const dst, size_t dst_size, const T &in) {
+            ssize_t rc = -1;
+            u8 *cur = dst;
+            std::memset(dst, 0, dst_size);
+
+            const size_t required = DNSSerializer::SizeOf(in);
+            if ((rc = DNSSerializer::CheckToBufferArguments(cur, dst_size, required, __LINE__)) == -1) {
+                return rc;
+            }
+            
+            AddrInfoNodeCname addr_info_node_cname;
+            const T *ares_addr_info = std::addressof(in);
+            if (ares_addr_info->cnames != nullptr) {
+                const struct ams::socket::ares_addrinfo_cname *ares_addr_info_cname;
+                for (ares_addr_info_cname = ares_addr_info->cnames; ares_addr_info_cname->next != nullptr; ares_addr_info_cname = ares_addr_info_cname->next) {
+                    /* Do nothing. */
+                }
+                addr_info_node_cname.ai_canonname = ares_addr_info_cname->name;
+            } else {
+                addr_info_node_cname.ai_canonname = ares_addr_info->name;
+            }
+
+            for (struct ams::socket::ares_addrinfo_node *ares_addr_info_node = ares_addr_info->nodes; ares_addr_info_node != nullptr; ares_addr_info_node = ares_addr_info_node->ai_next) {
+                addr_info_node_cname.node = ares_addr_info_node;
+                if ((rc = ToBufferInternalImpl(cur, dst_size, addr_info_node_cname)) == -1) {
+                    return rc;
+                }
+                
+                addr_info_node_cname.ai_canonname = nullptr;
+                cur += rc;
+            }
+            
+            rc = cur - dst;
+            return rc;
+        }
+        
+        template<typename T> requires IsAresAddrInfoHints<T>
+        ssize_t ToBufferImpl(u8 * const dst, size_t dst_size, const T &in) {
+            ssize_t rc = -1;
+            u8 *cur = dst;
+            
+            const size_t required = DNSSerializer::SizeOf(in);
+            if (dst_size < required) {
+                return rc;
+            }
+
+            {
+                const u32 value = AresMagic;
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(in.ai_flags);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(in.ai_family);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(in.ai_socktype);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                const u32 value = static_cast<u32>(in.ai_protocol);
+                if ((rc = DNSSerializer::ToBuffer(cur, dst_size - (cur - dst), value)) == -1) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            return rc;
+        }
+        
+        template<typename T> requires IsAresAddrInfoHints<T>
+        ssize_t FromBufferImpl(T &out, const u8 *src, size_t src_size) {
+            ssize_t rc = 0;
+            const u8 *cur = src;
+
+            const size_t required = DNSSerializer::SizeOf(out);
+            if (src_size < required) {
+                ams::socket::SetLastError(ams::socket::Errno::ENoSpc);
+                rc = -1;
+                return rc;
+            }
+            
+            std::memset(std::addressof(out), 0, sizeof(out));
+
+            u32 tmp_value;
+
+            {
+                if ((rc = DNSSerializer::FromBuffer(tmp_value, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                } else if (tmp_value != AresMagic) {
+                    return rc;
+                }
+                cur += rc;
+            }
+
+            {
+                if ((rc = DNSSerializer::FromBuffer(tmp_value, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                }
+                out.ai_flags = static_cast<decltype(out.ai_flags)>(tmp_value);
+                cur += rc;
+            }
+
+            {
+                if ((rc = DNSSerializer::FromBuffer(tmp_value, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                }
+                out.ai_family = static_cast<decltype(out.ai_family)>(tmp_value);
+                cur += rc;
+            }
+
+            {
+                if ((rc = DNSSerializer::FromBuffer(tmp_value, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                }
+                out.ai_socktype = static_cast<decltype(out.ai_socktype)>(tmp_value);
+                cur += rc;
+            }
+
+            {
+                if ((rc = DNSSerializer::FromBuffer(tmp_value, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                }
+                out.ai_protocol = static_cast<decltype(out.ai_protocol)>(tmp_value);
+                cur += rc;
+            }
+
+            rc = cur - src;
+            return rc;
+        }
+
+    }
+
+    template<>  size_t DNSSerializer::SizeOf(const struct ams::socket::ares_addrinfo &in) {
+        return SizeOfImpl(in);
+    }
+    
+    template<>  size_t DNSSerializer::SizeOf(const struct ams::socket::ares_addrinfo_hints &in) {
+        return SizeOfImpl(in);
+    }
+
+    /* NOTE: DNSSerializer::FromBuffer doesn't exist for ares_addrinfo, only DNSSerializer::ToBuffer does. */
+    /* Official software pairs it with the old addrinfo DNSSerializer::FromBuffer instead. */
+    template<> ssize_t DNSSerializer::ToBuffer(u8 * const dst, size_t dst_size, const struct ams::socket::ares_addrinfo &in) {
+        return ToBufferImpl(dst, dst_size, in);
+    }
+    
+    template<> ssize_t DNSSerializer::ToBuffer(u8 * const dst, size_t dst_size, const struct ams::socket::ares_addrinfo_hints &in) {
+        return ToBufferImpl(dst, dst_size, in);
+    }
+    
+    template<> ssize_t DNSSerializer::FromBuffer(struct ams::socket::ares_addrinfo_hints &out, const u8 *src, size_t src_size) {
+        return FromBufferImpl(out, src, src_size);
+    }
+}

stratosphere/ams_mitm/source/dns_mitm/serializer/serializer_impls_hostent.cpp

@@ -55,8 +55,9 @@ namespace ams::mitm::socket::resolver::serializer {
             rc += DNSSerializer::SizeOf((const char **)(in.h_aliases), dummy);
             rc += sizeof(u32);
             rc += sizeof(u32);
-            rc += DNSSerializer::SizeOf((const InAddrType<T> **)(in.h_addr_list), dummy);
-
+            if (IsAfInet<T>(in.h_addrtype)) {
+                rc += DNSSerializer::SizeOf((const InAddrType<T> **)(in.h_addr_list), dummy);
+            }
             return rc;
         }
 
@@ -150,7 +151,16 @@ namespace ams::mitm::socket::resolver::serializer {
             cur += rc;
 
             InAddrType<T> **addrs = nullptr;
-            if ((rc = DNSSerializer::FromBuffer(addrs, cur, src_size - (cur - src))) == -1) {
+            if (IsAfInet<T>(out.h_addrtype)) {
+                if ((rc = DNSSerializer::FromBuffer(addrs, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                }
+            } else if (IsAfInet6<T>(out.h_addrtype)) {
+                if ((rc = DNSSerializer::FromBuffer(addrs, cur, src_size - (cur - src))) == -1) {
+                    return rc;
+                }
+            } else {
+                rc = -1;
                 return rc;
             }
             out.h_addr_list = (char **)addrs;

stratosphere/ams_mitm/source/dns_mitm/serializer/serializer_impls_in_addr.cpp

@@ -159,6 +159,7 @@ namespace ams::mitm::socket::resolver::serializer {
 
             out = static_cast<T **>(ams::socket::impl::Alloc((count + 1) * sizeof(T *)));
             if (out == nullptr) {
+                ams::socket::SetLastError(ams::socket::Errno::ENoMem);
                 rc = -1;
                 return rc;
             }
@@ -167,6 +168,7 @@ namespace ams::mitm::socket::resolver::serializer {
             for (u32 i = 0; i < count; ++i) {
                 out[i] = static_cast<T *>(ams::socket::impl::Alloc(sizeof(T)));
                 if (out[i] == nullptr) {
+                    ams::socket::SetLastError(ams::socket::Errno::ENoMem);
                     rc = -1;
                     return rc;
                 }

stratosphere/ams_mitm/source/dns_mitm/serializer/serializer_impls_sockaddrin_6.cpp

@@ -31,7 +31,7 @@ namespace ams::mitm::socket::resolver::serializer {
             rc += sizeof(u16);
             rc += sizeof(u16);
             rc += sizeof(u32);
-            rc += DNSSerializer::SizeOf(in.sin6_addr);
+            rc += sizeof(in.sin6_addr); /* NOTE: There is no DNSSerializer::SizeOf for in6_addr. */
             rc += sizeof(u32);
             return rc;
         }

stratosphere/ams_mitm/source/dns_mitm/serializer/serializer_impls_string.cpp

@@ -76,6 +76,7 @@ namespace ams::mitm::socket::resolver::serializer {
 
         out = static_cast<char *>(ams::socket::impl::Alloc(len));
         if (out == nullptr) {
+            ams::socket::SetLastError(ams::socket::Errno::ENoMem);
             return -1;
         }
 
@@ -152,6 +153,7 @@ namespace ams::mitm::socket::resolver::serializer {
 
         out = static_cast<char **>(ams::socket::impl::Alloc((count + 1) * sizeof(char *)));
         if (out == nullptr) {
+            ams::socket::SetLastError(ams::socket::Errno::ENoMem);
             rc = -1;
             return rc;
         }
@@ -162,6 +164,7 @@ namespace ams::mitm::socket::resolver::serializer {
             const size_t len = std::strlen(reinterpret_cast<const char *>(cur));
             out[i] = static_cast<char *>(ams::socket::impl::Alloc(len + 1));
             if (out[i] == nullptr) {
+                ams::socket::SetLastError(ams::socket::Errno::ENoMem);
                 rc = -1;
                 return rc;
             }

stratosphere/ams_mitm/source/dns_mitm/sfdnsres_shim.c

@@ -95,3 +95,106 @@ Result sfdnsresGetAddrInfoRequestWithOptionsFwd(Service *s, u64 process_id, cons
     return rc;
 }
 
+Result sfdnsresReportTelemetryFwd(Service *s, u64 process_id, const void *telemetry, size_t telemetry_size, u32 version) {
+    const struct {
+        u32 version;
+        u32 padding;
+        u64 process_id;
+    } in = { version, 0, process_id };
+
+    return serviceMitmDispatchIn(s, 16, in,
+        .buffer_attrs = {
+            SfBufferAttr_HipcAutoSelect | SfBufferAttr_In
+        },
+        .buffers = {
+            { telemetry, telemetry_size }
+        },
+        .in_send_pid = true,
+        .override_pid = process_id,
+    );
+}
+
+Result sfdnsresQueryAddrInfoRequestWithOptionsFwd(Service *s, u64 process_id, const void *node, size_t node_size, const void *srv, size_t srv_size, const void *hint, size_t hint_size, u32 *out_query_id, u32 fd, u32 options_version, const void *option, size_t option_size, u32 num_options, s32 *out_rv, s32 *out_errno) {
+    const struct {
+        u32 fd;
+        u32 options_version;
+        u32 num_options;
+        u32 padding;
+        u64 process_id;
+    } in = { fd, options_version, num_options, 0, process_id };
+    struct {
+        u32 query_id;
+        s32 rv;
+        s32 errno;
+    } out;
+
+    Result rc = serviceMitmDispatchInOut(s, 100, in, out,
+        .buffer_attrs = {
+            SfBufferAttr_HipcAutoSelect | SfBufferAttr_In,
+            SfBufferAttr_HipcAutoSelect | SfBufferAttr_In,
+            SfBufferAttr_HipcAutoSelect | SfBufferAttr_In,
+            SfBufferAttr_HipcAutoSelect | SfBufferAttr_In
+        },
+        .buffers = {
+            { node, node_size },
+            { srv, srv_size },
+            { hint, hint_size },
+            { option, option_size }
+        },
+        .in_send_pid = true,
+        .override_pid = process_id,
+    );
+
+    if (R_SUCCEEDED(rc)) {
+        if (out_query_id) *out_query_id = out.query_id;
+        if (out_rv) *out_rv = out.rv;
+        if (out_errno) *out_errno = out.errno;
+    }
+
+    return rc;
+}
+
+Result sfdnsresFetchAddrInfoRequestWithOptionsFwd(Service *s, u64 process_id, u32 query_id, u32 version, void *out_ai, size_t out_ai_size, u32 *out_size, s32 *out_rv, s32 *out_errno) {
+    const struct {
+        u32 query_id;
+        u32 version;
+        u64 process_id;
+    } in = { query_id, version, process_id };
+    struct {
+        u32 size;
+        s32 rv;
+        s32 errno;
+    } out;
+
+    Result rc = serviceMitmDispatchInOut(s, 102, in, out,
+        .buffer_attrs = {
+            SfBufferAttr_HipcAutoSelect | SfBufferAttr_Out
+        },
+        .buffers = {
+            { out_ai, out_ai_size }
+        },
+        .in_send_pid = true,
+        .override_pid = process_id,
+    );
+
+    if (R_SUCCEEDED(rc)) {
+        if (out_size) *out_size = out.size;
+        if (out_rv) *out_rv = out.rv;
+        if (out_errno) *out_errno = out.errno;
+    }
+
+    return rc;
+}
+
+Result sfdnsresCancelQueryFwd(Service *s, u64 process_id, u32 query_id) {
+    const struct {
+        u32 query_id;
+        u32 padding;
+        u64 process_id;
+    } in = { query_id, 0, process_id };
+    
+    return serviceMitmDispatchIn(s, 104, in,
+        .in_send_pid = true,
+        .override_pid = process_id,
+    );
+}

stratosphere/ams_mitm/source/dns_mitm/sfdnsres_shim.h

@@ -16,6 +16,14 @@ Result sfdnsresGetHostByNameRequestWithOptionsFwd(Service *s, u64 process_id, co
 
 Result sfdnsresGetAddrInfoRequestWithOptionsFwd(Service *s, u64 process_id, const void *node, size_t node_size, const void *srv, size_t srv_size, const void *hint, size_t hint_size, void *out_ai, size_t out_ai_size, u32 *out_size, s32 *out_rv, u32 options_version, const void *option, size_t option_size, u32 num_options, s32 *out_host_error, s32 *out_errno);
 
+Result sfdnsresReportTelemetryFwd(Service *s, u64 process_id, const void *telemetry, size_t telemetry_size, u32 version);
+
+Result sfdnsresQueryAddrInfoRequestWithOptionsFwd(Service *s, u64 process_id, const void *node, size_t node_size, const void *srv, size_t srv_size, const void *hint, size_t hint_size, u32 *out_query_id, u32 fd, u32 options_version, const void *option, size_t option_size, u32 num_options, s32 *out_rv, s32 *out_errno);
+
+Result sfdnsresFetchAddrInfoRequestWithOptionsFwd(Service *s, u64 process_id, u32 query_id, u32 version, void *out_ai, size_t out_ai_size, u32 *out_size, s32 *out_rv, s32 *out_errno);
+
+Result sfdnsresCancelQueryFwd(Service *s, u64 process_id, u32 query_id);
+
 #ifdef __cplusplus
 }
 #endif

stratosphere/ams_mitm/source/fs_mitm/fs_mitm_service.cpp

@@ -67,6 +67,11 @@ namespace ams::mitm::fs {
         constexpr ALWAYS_INLINE auto MakeSharedStorage(Arguments &&... args) {
             return sf::CreateSharedObjectEmplaced<ams::fssrv::sf::IStorage, ams::fssrv::impl::StorageInterfaceAdapter>(std::forward<Arguments>(args)...);
         }
+        
+        template<typename... Arguments>
+        constexpr ALWAYS_INLINE auto MakeSharedStorageForBatchRead(Arguments &&... args) {
+            return sf::CreateSharedObjectEmplaced<ams::fssrv::sf::IStorageForBatchRead, ams::fssrv::impl::StorageInterfaceAdapterForBatchRead>(std::forward<Arguments>(args)...);
+        }
 
         Result OpenHblWebContentFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> &out, ncm::ProgramId program_id) {
             /* Verify eligibility. */
@@ -94,7 +99,7 @@ namespace ams::mitm::fs {
             R_SUCCEED();
         }
 
-        Result OpenProgramSpecificWebContentFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> &out, ncm::ProgramId program_id, FsFileSystemType filesystem_type, Service *fwd, const fssrv::sf::Path *path, bool with_id) {
+        Result OpenProgramSpecificWebContentFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> &out, ncm::ProgramId program_id, FsFileSystemType filesystem_type, Service *fwd, const fssrv::sf::Path *path, bool with_id, bool with_attributes) {
             /* Directory must exist. */
             R_UNLESS(HasSdManualHtmlContent(program_id), sm::mitm::ResultShouldForwardToSession());
 
@@ -121,8 +126,10 @@ namespace ams::mitm::fs {
                 /* Try to open the existing fs. */
                 FsFileSystem base_fs;
                 bool opened_base_fs = false;
-                if (with_id) {
-                    opened_base_fs = R_SUCCEEDED(fsOpenFileSystemWithIdFwd(fwd, std::addressof(base_fs), static_cast<u64>(program_id), filesystem_type, path->str));
+                if (with_attributes) {
+                    opened_base_fs = R_SUCCEEDED(fsOpenFileSystemWithIdFwd(fwd, std::addressof(base_fs), path->str, FsContentAttributes_None, static_cast<u64>(program_id), filesystem_type));
+                } else if (with_id) {
+                    opened_base_fs = R_SUCCEEDED(fsOpenFileSystemWithIdObsoleteFwd(fwd, std::addressof(base_fs), path->str, static_cast<u64>(program_id), filesystem_type));
                 } else {
                     opened_base_fs = R_SUCCEEDED(fsOpenFileSystemWithPatchFwd(fwd, std::addressof(base_fs), static_cast<u64>(program_id), filesystem_type));
                 }
@@ -141,7 +148,7 @@ namespace ams::mitm::fs {
             R_SUCCEED();
         }
 
-        Result OpenWebContentFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> &out, ncm::ProgramId client_program_id, ncm::ProgramId program_id, FsFileSystemType filesystem_type, Service *fwd, const fssrv::sf::Path *path, bool with_id, bool try_program_specific) {
+        Result OpenWebContentFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> &out, ncm::ProgramId client_program_id, ncm::ProgramId program_id, FsFileSystemType filesystem_type, Service *fwd, const fssrv::sf::Path *path, bool with_id, bool with_attributes, bool try_program_specific) {
             /* Check first that we're a web applet opening web content. */
             R_UNLESS(ncm::IsWebAppletId(client_program_id),             sm::mitm::ResultShouldForwardToSession());
             R_UNLESS(filesystem_type == FsFileSystemType_ContentManual, sm::mitm::ResultShouldForwardToSession());
@@ -153,7 +160,7 @@ namespace ams::mitm::fs {
             R_UNLESS(try_program_specific, sm::mitm::ResultShouldForwardToSession());
 
             /* If we're not opening a HBL filesystem, just try to open a generic one. */
-            R_RETURN(OpenProgramSpecificWebContentFileSystem(out, program_id, filesystem_type, fwd, path, with_id));
+            R_RETURN(OpenProgramSpecificWebContentFileSystem(out, program_id, filesystem_type, fwd, path, with_id, with_attributes));
         }
 
     }
@@ -169,12 +176,17 @@ namespace ams::mitm::fs {
         }
     }
 
-    Result FsMitmService::OpenFileSystemWithPatch(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, ncm::ProgramId program_id, u32 _filesystem_type) {
-        R_RETURN(OpenWebContentFileSystem(out, m_client_info.program_id, program_id, static_cast<FsFileSystemType>(_filesystem_type), m_forward_service.get(), nullptr, false, m_client_info.override_status.IsProgramSpecific()));
+    Result FsMitmService::OpenFileSystemWithPatch(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, ncm::ProgramId program_id, u32 file_system_proxy_type) {
+        R_RETURN(OpenWebContentFileSystem(out, m_client_info.program_id, program_id, static_cast<FsFileSystemType>(file_system_proxy_type), m_forward_service.get(), nullptr, false, false, m_client_info.override_status.IsProgramSpecific()));
     }
 
-    Result FsMitmService::OpenFileSystemWithId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, ncm::ProgramId program_id, u32 _filesystem_type) {
-        R_RETURN(OpenWebContentFileSystem(out, m_client_info.program_id, program_id, static_cast<FsFileSystemType>(_filesystem_type), m_forward_service.get(), std::addressof(path), true, m_client_info.override_status.IsProgramSpecific()));
+    Result FsMitmService::OpenFileSystemWithIdObsolete(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, ncm::ProgramId program_id, u32 file_system_proxy_type) {
+        R_RETURN(OpenWebContentFileSystem(out, m_client_info.program_id, program_id, static_cast<FsFileSystemType>(file_system_proxy_type), m_forward_service.get(), std::addressof(path), true, false, m_client_info.override_status.IsProgramSpecific()));
+    }
+    
+    Result FsMitmService::OpenFileSystemWithId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, u8 content_attributes, ncm::ProgramId program_id, u32 file_system_proxy_type) {
+        AMS_UNUSED(content_attributes);
+        R_RETURN(OpenWebContentFileSystem(out, m_client_info.program_id, program_id, static_cast<FsFileSystemType>(file_system_proxy_type), m_forward_service.get(), std::addressof(path), true, true, m_client_info.override_status.IsProgramSpecific()));
     }
 
     Result FsMitmService::OpenSdCardFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out) {
@@ -195,7 +207,7 @@ namespace ams::mitm::fs {
         R_SUCCEED();
     }
 
-    Result FsMitmService::OpenSaveDataFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, u8 _space_id, const fs::SaveDataAttribute &attribute) {
+    Result FsMitmService::OpenSaveDataFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, u8 space_id, const fs::SaveDataAttribute &attribute) {
         /* We only want to intercept saves for games, right now. */
         const bool is_game_or_hbl = m_client_info.override_status.IsHbl() || ncm::IsApplicationId(m_client_info.program_id);
         R_UNLESS(is_game_or_hbl, sm::mitm::ResultShouldForwardToSession());
@@ -210,12 +222,12 @@ namespace ams::mitm::fs {
         R_UNLESS(attribute.type == fs::SaveDataType::Account, sm::mitm::ResultShouldForwardToSession());
 
         /* Get enum type for space id. */
-        auto space_id = static_cast<FsSaveDataSpaceId>(_space_id);
+        auto _space_id = static_cast<FsSaveDataSpaceId>(space_id);
 
         /* Verify we can open the save. */
         static_assert(sizeof(fs::SaveDataAttribute) == sizeof(::FsSaveDataAttribute));
         FsFileSystem save_fs;
-        R_UNLESS(R_SUCCEEDED(fsOpenSaveDataFileSystemFwd(m_forward_service.get(), std::addressof(save_fs), space_id, reinterpret_cast<const FsSaveDataAttribute *>(std::addressof(attribute)))), sm::mitm::ResultShouldForwardToSession());
+        R_UNLESS(R_SUCCEEDED(fsOpenSaveDataFileSystemFwd(m_forward_service.get(), std::addressof(save_fs), _space_id, reinterpret_cast<const FsSaveDataAttribute *>(std::addressof(attribute)))), sm::mitm::ResultShouldForwardToSession());
         std::unique_ptr<fs::fsa::IFileSystem> save_ifs = std::make_unique<fs::RemoteFileSystem>(save_fs);
 
         /* Mount the SD card using fs.mitm's session. */
@@ -228,7 +240,7 @@ namespace ams::mitm::fs {
         const ncm::ProgramId application_id = attribute.program_id == ncm::InvalidProgramId ? m_client_info.program_id : attribute.program_id;
 
         char save_dir_raw_path[0x100];
-        R_TRY(mitm::fs::SaveUtil::GetDirectorySaveDataPath(save_dir_raw_path, sizeof(save_dir_raw_path), application_id, space_id, attribute));
+        R_TRY(mitm::fs::SaveUtil::GetDirectorySaveDataPath(save_dir_raw_path, sizeof(save_dir_raw_path), application_id, _space_id, attribute));
 
         ams::fs::Path save_dir_path;
         R_TRY(save_dir_path.SetShallowBuffer(save_dir_raw_path));
@@ -270,12 +282,12 @@ namespace ams::mitm::fs {
         R_SUCCEED();
     }
 
-    Result FsMitmService::OpenBisStorage(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u32 _bis_partition_id) {
-        const ::FsBisPartitionId bis_partition_id = static_cast<::FsBisPartitionId>(_bis_partition_id);
+    Result FsMitmService::OpenBisStorage(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u32 bis_partition_id) {
+        const ::FsBisPartitionId _bis_partition_id = static_cast<::FsBisPartitionId>(bis_partition_id);
 
         /* Try to open a storage for the partition. */
         FsStorage bis_storage;
-        R_TRY(fsOpenBisStorageFwd(m_forward_service.get(), std::addressof(bis_storage), bis_partition_id));
+        R_TRY(fsOpenBisStorageFwd(m_forward_service.get(), std::addressof(bis_storage), _bis_partition_id));
         const sf::cmif::DomainObjectId target_object_id{serviceGetObjectId(std::addressof(bis_storage.s))};
 
         const bool is_sysmodule = ncm::IsSystemProgramId(m_client_info.program_id);
@@ -285,18 +297,18 @@ namespace ams::mitm::fs {
         /* Allow HBL to write to boot1 (safe firm) + package2. */
         /* This is needed to not break compatibility with ChoiDujourNX, which does not check for write access before beginning an update. */
         /* TODO: get fixed so that this can be turned off without causing bricks :/ */
-        const bool is_package2 = (FsBisPartitionId_BootConfigAndPackage2Part1 <= bis_partition_id && bis_partition_id <= FsBisPartitionId_BootConfigAndPackage2Part6);
-        const bool is_boot1    = bis_partition_id == FsBisPartitionId_BootPartition2Root;
+        const bool is_package2 = (FsBisPartitionId_BootConfigAndPackage2Part1 <= _bis_partition_id && _bis_partition_id <= FsBisPartitionId_BootConfigAndPackage2Part6);
+        const bool is_boot1    = _bis_partition_id == FsBisPartitionId_BootPartition2Root;
         const bool can_write_bis_for_choi_support = is_hbl && (is_package2 || is_boot1);
 
         /* Set output storage. */
-        if (bis_partition_id == FsBisPartitionId_BootPartition1Root) {
+        if (_bis_partition_id == FsBisPartitionId_BootPartition1Root) {
             if (IsBoot0CustomPublicKey(bis_storage)) {
                 out.SetValue(MakeSharedStorage(std::make_shared<CustomPublicKeyBoot0Storage>(bis_storage, m_client_info, spl::GetSocType())), target_object_id);
             } else {
                 out.SetValue(MakeSharedStorage(std::make_shared<Boot0Storage>(bis_storage, m_client_info)), target_object_id);
             }
-        } else if (bis_partition_id == FsBisPartitionId_CalibrationBinary) {
+        } else if (_bis_partition_id == FsBisPartitionId_CalibrationBinary) {
             out.SetValue(MakeSharedStorage(std::make_shared<CalibrationBinaryStorage>(bis_storage, m_client_info)), target_object_id);
         } else {
             if (can_write_bis || can_write_bis_for_choi_support) {
@@ -328,24 +340,41 @@ namespace ams::mitm::fs {
         out.SetValue(MakeSharedStorage(GetLayeredRomfsStorage(m_client_info.program_id, data_storage, true)), target_object_id);
         R_SUCCEED();
     }
+    
+    Result FsMitmService::OpenDataStorageByProgramId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::ProgramId program_id) {
+        /* Only mitm if we should override contents for the current process. */
+        R_UNLESS(m_client_info.override_status.IsProgramSpecific(),     sm::mitm::ResultShouldForwardToSession());
 
-    Result FsMitmService::OpenDataStorageByDataId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::DataId _data_id, u8 storage_id) {
+        /* Only mitm if there is actually an override romfs for the target program. */
+        R_UNLESS(mitm::fs::HasSdRomfsContent(program_id), sm::mitm::ResultShouldForwardToSession());
+
+        /* Try to open the program romfs. */
+        FsStorage data_storage;
+        R_TRY(fsOpenDataStorageByProgramIdFwd(m_forward_service.get(), std::addressof(data_storage), static_cast<u64>(program_id)));
+        const sf::cmif::DomainObjectId target_object_id{serviceGetObjectId(std::addressof(data_storage.s))};
+
+        /* Get a layered storage for the program romfs. */
+        out.SetValue(MakeSharedStorage(GetLayeredRomfsStorage(program_id, data_storage, true)), target_object_id);
+        R_SUCCEED();
+    }
+
+    Result FsMitmService::OpenDataStorageByDataId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::DataId data_id, u8 storage_id) {
         /* Only mitm if we should override contents for the current process. */
         R_UNLESS(m_client_info.override_status.IsProgramSpecific(), sm::mitm::ResultShouldForwardToSession());
 
         /* TODO: Decide how to handle DataId vs ProgramId for this API. */
-        const ncm::ProgramId data_id = {_data_id.value};
+        const ncm::ProgramId program_or_data_id = {data_id.value};
 
         /* Only mitm if there is actually an override romfs. */
-        R_UNLESS(mitm::fs::HasSdRomfsContent(data_id),                  sm::mitm::ResultShouldForwardToSession());
+        R_UNLESS(mitm::fs::HasSdRomfsContent(program_or_data_id),                  sm::mitm::ResultShouldForwardToSession());
 
         /* Try to open the data id. */
         FsStorage data_storage;
-        R_TRY(fsOpenDataStorageByDataIdFwd(m_forward_service.get(), std::addressof(data_storage), static_cast<u64>(data_id), static_cast<NcmStorageId>(storage_id)));
+        R_TRY(fsOpenDataStorageByDataIdFwd(m_forward_service.get(), std::addressof(data_storage), static_cast<u64>(program_or_data_id), static_cast<NcmStorageId>(storage_id)));
         const sf::cmif::DomainObjectId target_object_id{serviceGetObjectId(std::addressof(data_storage.s))};
 
         /* Get a layered storage for the data id. */
-        out.SetValue(MakeSharedStorage(GetLayeredRomfsStorage(data_id, data_storage, false)), target_object_id);
+        out.SetValue(MakeSharedStorage(GetLayeredRomfsStorage(program_or_data_id, data_storage, false)), target_object_id);
         R_SUCCEED();
     }
 
@@ -369,7 +398,80 @@ namespace ams::mitm::fs {
         out.SetValue(MakeSharedStorage(GetLayeredRomfsStorage(program_id, data_storage, true)), target_object_id);
         R_SUCCEED();
     }
+    
+    Result FsMitmService::OpenDataStorageByPath(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, const fssrv::sf::Path &path, u8 content_attributes, u32 file_system_proxy_type) {
+        /* Only mitm if we should override contents for the current process. */
+        R_UNLESS(m_client_info.override_status.IsProgramSpecific(),     sm::mitm::ResultShouldForwardToSession());
+        
+        /* TODO */
+        AMS_UNUSED(out, path, content_attributes, file_system_proxy_type);
+        R_SUCCEED();
+    }
+    
+    Result FsMitmService::OpenDataStorageByCurrentProcessForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out) {
+        /* Only mitm if we should override contents for the current process. */
+        R_UNLESS(m_client_info.override_status.IsProgramSpecific(),     sm::mitm::ResultShouldForwardToSession());
 
+        /* Only mitm if there is actually an override romfs. */
+        R_UNLESS(mitm::fs::HasSdRomfsContent(m_client_info.program_id), sm::mitm::ResultShouldForwardToSession());
+
+        /* Try to open the process romfs. */
+        FsStorageForBatchRead data_storage;
+        R_TRY(fsOpenDataStorageByCurrentProcessForBatchReadFwd(m_forward_service.get(), std::addressof(data_storage)));
+        const sf::cmif::DomainObjectId target_object_id{serviceGetObjectId(std::addressof(data_storage.s))};
+
+        /* Get a layered storage for the program romfs (batch read variant). */
+        out.SetValue(MakeSharedStorageForBatchRead(GetLayeredRomfsStorageForBatchRead(m_client_info.program_id, data_storage, true)), target_object_id);
+        R_SUCCEED();
+    }
+    
+    Result FsMitmService::OpenDataStorageByProgramIdForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, ncm::ProgramId program_id) {
+        /* Only mitm if we should override contents for the current process. */
+        R_UNLESS(m_client_info.override_status.IsProgramSpecific(),     sm::mitm::ResultShouldForwardToSession());
+
+        /* Only mitm if there is actually an override romfs for the target program. */
+        R_UNLESS(mitm::fs::HasSdRomfsContent(program_id), sm::mitm::ResultShouldForwardToSession());
+
+        /* Try to open the program romfs. */
+        FsStorageForBatchRead data_storage;
+        R_TRY(fsOpenDataStorageByProgramIdForBatchReadFwd(m_forward_service.get(), std::addressof(data_storage), static_cast<u64>(program_id)));
+        const sf::cmif::DomainObjectId target_object_id{serviceGetObjectId(std::addressof(data_storage.s))};
+
+        /* Get a layered storage for the program romfs (batch read variant). */
+        out.SetValue(MakeSharedStorageForBatchRead(GetLayeredRomfsStorageForBatchRead(program_id, data_storage, true)), target_object_id);
+        R_SUCCEED();
+    }
+    
+    Result FsMitmService::OpenDataStorageWithProgramIndexForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, u8 program_index) {
+        /* Only mitm if we should override contents for the current process. */
+        R_UNLESS(m_client_info.override_status.IsProgramSpecific(), sm::mitm::ResultShouldForwardToSession());
+
+        /* Get the relevant program id. */
+        const ncm::ProgramId program_id = g_program_index_map_info_manager.GetProgramId(m_client_info.program_id, program_index);
+
+        /* If we don't know about the program or don't have content, forward. */
+        R_UNLESS(program_id != ncm::InvalidProgramId,     sm::mitm::ResultShouldForwardToSession());
+        R_UNLESS(mitm::fs::HasSdRomfsContent(program_id), sm::mitm::ResultShouldForwardToSession());
+
+        /* Try to open the process romfs. */
+        FsStorageForBatchRead data_storage;
+        R_TRY(fsOpenDataStorageWithProgramIndexForBatchReadFwd(m_forward_service.get(), std::addressof(data_storage), program_index));
+        const sf::cmif::DomainObjectId target_object_id{serviceGetObjectId(std::addressof(data_storage.s))};
+
+        /* Get a layered storage for the program romfs (batch read variant). */
+        out.SetValue(MakeSharedStorageForBatchRead(GetLayeredRomfsStorageForBatchRead(program_id, data_storage, true)), target_object_id);
+        R_SUCCEED();
+    }
+    
+    Result FsMitmService::OpenDataStorageByPathForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, const fssrv::sf::Path &path, u8 content_attributes, u32 file_system_proxy_type) {
+        /* Only mitm if we should override contents for the current process. */
+        R_UNLESS(m_client_info.override_status.IsProgramSpecific(),     sm::mitm::ResultShouldForwardToSession());
+        
+        /* TODO */
+        AMS_UNUSED(out, path, content_attributes, file_system_proxy_type);
+        R_SUCCEED();
+    }
+    
     Result FsMitmService::RegisterProgramIndexMapInfo(const sf::InBuffer &info_buffer, s32 info_count) {
         /* Try to register with FS. */
         R_TRY(fsRegisterProgramIndexMapInfoFwd(m_forward_service.get(), info_buffer.GetPointer(), info_buffer.GetSize(), info_count));

stratosphere/ams_mitm/source/fs_mitm/fs_mitm_service.hpp

@@ -17,16 +17,23 @@
 #include <stratosphere.hpp>
 #include <stratosphere/fssrv/fssrv_interface_adapters.hpp>
 
-#define AMS_FS_MITM_INTERFACE_INFO(C, H)                                                                                                                                                                                                                                               \
-    AMS_SF_METHOD_INFO(C, H,   7, Result, OpenFileSystemWithPatch,         (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, ncm::ProgramId program_id, u32 _filesystem_type),                              (out, program_id, _filesystem_type),       hos::Version_2_0_0) \
-    AMS_SF_METHOD_INFO(C, H,   8, Result, OpenFileSystemWithId,            (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, ncm::ProgramId program_id, u32 _filesystem_type), (out, path, program_id, _filesystem_type), hos::Version_2_0_0) \
-    AMS_SF_METHOD_INFO(C, H,  18, Result, OpenSdCardFileSystem,            (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out),                                                                               (out))                                                         \
-    AMS_SF_METHOD_INFO(C, H,  51, Result, OpenSaveDataFileSystem,          (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, u8 space_id, const ams::fs::SaveDataAttribute &attribute),                     (out, space_id, attribute))                                    \
-    AMS_SF_METHOD_INFO(C, H,  12, Result, OpenBisStorage,                  (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u32 bis_partition_id),                                                            (out, bis_partition_id))                                       \
-    AMS_SF_METHOD_INFO(C, H, 200, Result, OpenDataStorageByCurrentProcess, (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out),                                                                                  (out))                                                         \
-    AMS_SF_METHOD_INFO(C, H, 202, Result, OpenDataStorageByDataId,         (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::DataId data_id, u8 storage_id),                                              (out, data_id, storage_id))                                    \
-    AMS_SF_METHOD_INFO(C, H, 205, Result, OpenDataStorageWithProgramIndex, (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u8 program_index),                                                                (out, program_index),                      hos::Version_7_0_0) \
-    AMS_SF_METHOD_INFO(C, H, 810, Result, RegisterProgramIndexMapInfo,     (const sf::InBuffer &info_buffer, s32 info_count),                                                                                           (info_buffer, info_count),                 hos::Version_7_0_0)
+#define AMS_FS_MITM_INTERFACE_INFO(C, H)                                                                                                                                                                                                                                                                                                                   \
+    AMS_SF_METHOD_INFO(C, H,   7, Result, OpenFileSystemWithPatch,                     (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, ncm::ProgramId program_id, u32 file_system_proxy_type),                                                     (out, program_id, file_system_proxy_type),                           hos::Version_2_0_0)  \
+    AMS_SF_METHOD_INFO(C, H,   8, Result, OpenFileSystemWithIdObsolete,                (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, ncm::ProgramId program_id, u32 file_system_proxy_type),                        (out, path, program_id, file_system_proxy_type),                     hos::Version_2_0_0)  \
+    AMS_SF_METHOD_INFO(C, H,  10, Result, OpenFileSystemWithId,                        (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, u8 content_attributes, ncm::ProgramId program_id, u32 file_system_proxy_type), (out, path, content_attributes, program_id, file_system_proxy_type), hos::Version_16_0_0) \
+    AMS_SF_METHOD_INFO(C, H,  18, Result, OpenSdCardFileSystem,                        (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out),                                                                                                            (out))                                                                                    \
+    AMS_SF_METHOD_INFO(C, H,  51, Result, OpenSaveDataFileSystem,                      (sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, u8 space_id, const ams::fs::SaveDataAttribute &attribute),                                                  (out, space_id, attribute))                                                               \
+    AMS_SF_METHOD_INFO(C, H,  12, Result, OpenBisStorage,                              (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u32 bis_partition_id),                                                                                         (out, bis_partition_id))                                                                  \
+    AMS_SF_METHOD_INFO(C, H, 200, Result, OpenDataStorageByCurrentProcess,             (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out),                                                                                                               (out))                                                                                    \
+    AMS_SF_METHOD_INFO(C, H, 201, Result, OpenDataStorageByProgramId,                  (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::ProgramId program_id),                                                                                    (out, program_id),                                                   hos::Version_3_0_0)  \
+    AMS_SF_METHOD_INFO(C, H, 202, Result, OpenDataStorageByDataId,                     (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::DataId data_id, u8 storage_id),                                                                           (out, data_id, storage_id))                                                               \
+    AMS_SF_METHOD_INFO(C, H, 205, Result, OpenDataStorageWithProgramIndex,             (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u8 program_index),                                                                                             (out, program_index),                                                hos::Version_7_0_0)  \
+    AMS_SF_METHOD_INFO(C, H, 206, Result, OpenDataStorageByPath,                       (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, const fssrv::sf::Path &path, u8 content_attributes, u32 file_system_proxy_type),                               (out, path, content_attributes, file_system_proxy_type),             hos::Version_13_0_0) \
+    AMS_SF_METHOD_INFO(C, H, 210, Result, OpenDataStorageByCurrentProcessForBatchRead, (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out),                                                                                                   (out),                                                               hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H, 211, Result, OpenDataStorageByProgramIdForBatchRead,      (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, ncm::ProgramId program_id),                                                                        (out, program_id),                                                   hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H, 212, Result, OpenDataStorageWithProgramIndexForBatchRead, (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, u8 program_index),                                                                                 (out, program_index),                                                hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H, 213, Result, OpenDataStorageByPathForBatchRead,           (sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, const fssrv::sf::Path &path, u8 content_attributes, u32 file_system_proxy_type),                   (out, path, content_attributes, file_system_proxy_type),             hos::Version_23_0_0) \
+    AMS_SF_METHOD_INFO(C, H, 810, Result, RegisterProgramIndexMapInfo,                 (const sf::InBuffer &info_buffer, s32 info_count),                                                                                                                        (info_buffer, info_count),                                           hos::Version_7_0_0)
 
 
 AMS_SF_DEFINE_MITM_INTERFACE(ams::mitm::fs, IFsMitmInterface, AMS_FS_MITM_INTERFACE_INFO, 0x7DF34ED2)
@@ -77,14 +84,21 @@ namespace ams::mitm::fs {
             }
         public:
             /* Overridden commands. */
-            Result OpenFileSystemWithPatch(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, ncm::ProgramId program_id, u32 _filesystem_type);
-            Result OpenFileSystemWithId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, ncm::ProgramId program_id, u32 _filesystem_type);
+            Result OpenFileSystemWithPatch(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, ncm::ProgramId program_id, u32 file_system_proxy_type);
+            Result OpenFileSystemWithIdObsolete(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, ncm::ProgramId program_id, u32 file_system_proxy_type);
+            Result OpenFileSystemWithId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, const fssrv::sf::Path &path, u8 content_attributes, ncm::ProgramId program_id, u32 file_system_proxy_type);
             Result OpenSdCardFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out);
             Result OpenSaveDataFileSystem(sf::Out<sf::SharedPointer<ams::fssrv::sf::IFileSystem>> out, u8 space_id, const ams::fs::SaveDataAttribute &attribute);
             Result OpenBisStorage(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u32 bis_partition_id);
             Result OpenDataStorageByCurrentProcess(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out);
+            Result OpenDataStorageByProgramId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::ProgramId program_id);
             Result OpenDataStorageByDataId(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, ncm::DataId data_id, u8 storage_id);
             Result OpenDataStorageWithProgramIndex(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, u8 program_index);
+            Result OpenDataStorageByPath(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorage>> out, const fssrv::sf::Path &path, u8 content_attributes, u32 file_system_proxy_type);
+            Result OpenDataStorageByCurrentProcessForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out);
+            Result OpenDataStorageByProgramIdForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, ncm::ProgramId program_id);
+            Result OpenDataStorageWithProgramIndexForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, u8 program_index);
+            Result OpenDataStorageByPathForBatchRead(sf::Out<sf::SharedPointer<ams::fssrv::sf::IStorageForBatchRead>> out, const fssrv::sf::Path &path, u8 content_attributes, u32 file_system_proxy_type);
             Result RegisterProgramIndexMapInfo(const sf::InBuffer &info_buffer, s32 info_count);
     };
     static_assert(IsIFsMitmInterface<FsMitmService>);

stratosphere/ams_mitm/source/fs_mitm/fs_shim.c

@@ -23,8 +23,46 @@ static Result _fsOpenSession(Service *s, Service* out, u32 cmd_id) {
     );
 }
 
-Result fsOpenSdCardFileSystemFwd(Service* s, FsFileSystem* out) {
-    return _fsOpenSession(s, &out->s, 18);
+Result fsOpenFileSystemWithPatchFwd(Service* s, FsFileSystem* out, u64 id, FsFileSystemType fsType) {
+    const struct {
+        u32 fsType;
+        u64 id;
+    } in = { fsType, id };
+
+    return serviceDispatchIn(s, 7, in,
+        .out_num_objects = 1,
+        .out_objects = &out->s
+    );
+}
+
+Result fsOpenFileSystemWithIdObsoleteFwd(Service* s, FsFileSystem* out, const char* contentPath, u64 id, FsFileSystemType fsType) {
+    const struct {
+        u32 fsType;
+        u64 id;
+    } in = { fsType, id };
+
+    return serviceDispatchIn(s, 8, in,
+        .buffer_attrs = { SfBufferAttr_In | SfBufferAttr_HipcPointer | SfBufferAttr_FixedSize },
+        .buffers = { { contentPath, FS_MAX_PATH } },
+        .out_num_objects = 1,
+        .out_objects = &out->s
+    );
+}
+
+Result fsOpenFileSystemWithIdFwd(Service* s, FsFileSystem* out, const char* contentPath, FsContentAttributes attributes, u64 id, FsFileSystemType fsType) {
+    const struct {
+        u8 attributes;
+        u8 pad[3];
+        u32 fsType;
+        u64 id;
+    } in = { attributes, {0}, fsType, id };
+
+    return serviceDispatchIn(s, 10, in,
+        .buffer_attrs = { SfBufferAttr_In | SfBufferAttr_HipcPointer | SfBufferAttr_FixedSize },
+        .buffers = { { contentPath, FS_MAX_PATH } },
+        .out_num_objects = 1,
+        .out_objects = &out->s
+    );
 }
 
 Result fsOpenBisStorageFwd(Service* s, FsStorage* out, FsBisPartitionId partition_id) {
@@ -35,10 +73,34 @@ Result fsOpenBisStorageFwd(Service* s, FsStorage* out, FsBisPartitionId partitio
     );
 }
 
+Result fsOpenSdCardFileSystemFwd(Service* s, FsFileSystem* out) {
+    return _fsOpenSession(s, &out->s, 18);
+}
+
+Result fsOpenSaveDataFileSystemFwd(Service* s, FsFileSystem* out, FsSaveDataSpaceId save_data_space_id, const FsSaveDataAttribute *attr) {
+    const struct {
+        u8 save_data_space_id;
+        u8 pad[7];
+        FsSaveDataAttribute attr;
+    } in = { (u8)save_data_space_id, {0}, *attr };
+
+    return serviceDispatchIn(s, 51, in,
+        .out_num_objects = 1,
+        .out_objects = &out->s,
+    );
+}
+
 Result fsOpenDataStorageByCurrentProcessFwd(Service* s, FsStorage* out) {
     return _fsOpenSession(s, &out->s, 200);
 }
 
+Result fsOpenDataStorageByProgramIdFwd(Service* s, FsStorage* out, u64 id) {
+    return serviceDispatchIn(s, 201, id,
+        .out_num_objects = 1,
+        .out_objects = &out->s,
+    );
+}
+
 Result fsOpenDataStorageByDataIdFwd(Service* s, FsStorage* out, u64 data_id, NcmStorageId storage_id) {
     const struct {
         u8 storage_id;
@@ -58,48 +120,57 @@ Result fsOpenDataStorageWithProgramIndexFwd(Service* s, FsStorage* out, u8 progr
     );
 }
 
-Result fsRegisterProgramIndexMapInfoFwd(Service* s, const void *buf, size_t buf_size, s32 count) {
-    return serviceDispatchIn(s, 810, count,
-        .buffer_attrs = { SfBufferAttr_HipcMapAlias | SfBufferAttr_In },
-        .buffers = { { buf, buf_size } },
+Result fsOpenDataStorageByPathFwd(Service* s, FsStorage* out, const char* contentPath, FsContentAttributes attributes, FsFileSystemType fsType) {
+    const struct {
+        u8 attributes;
+        u8 pad[3];
+        u32 fsType;
+    } in = { attributes, {0}, fsType };
+
+    return serviceDispatchIn(s, 206, in,
+        .buffer_attrs = { SfBufferAttr_In | SfBufferAttr_HipcPointer | SfBufferAttr_FixedSize },
+        .buffers = { { contentPath, FS_MAX_PATH } },
+        .out_num_objects = 1,
+        .out_objects = &out->s
     );
 }
 
-Result fsOpenSaveDataFileSystemFwd(Service* s, FsFileSystem* out, FsSaveDataSpaceId save_data_space_id, const FsSaveDataAttribute *attr) {
-    const struct {
-        u8 save_data_space_id;
-        u8 pad[7];
-        FsSaveDataAttribute attr;
-    } in = { (u8)save_data_space_id, {0}, *attr };
+Result fsOpenDataStorageByCurrentProcessForBatchReadFwd(Service* s, FsStorageForBatchRead* out) {
+    return _fsOpenSession(s, &out->s, 210);
+}
 
-    return serviceDispatchIn(s, 51, in,
+Result fsOpenDataStorageByProgramIdForBatchReadFwd(Service* s, FsStorageForBatchRead* out, u64 id) {
+    return serviceDispatchIn(s, 211, id,
         .out_num_objects = 1,
         .out_objects = &out->s,
     );
 }
 
-Result fsOpenFileSystemWithPatchFwd(Service* s, FsFileSystem* out, u64 id, FsFileSystemType fsType) {
-    const struct {
-        u32 fsType;
-        u64 id;
-    } in = { fsType, id };
+Result fsOpenDataStorageWithProgramIndexForBatchReadFwd(Service* s, FsStorageForBatchRead* out, u8 program_index) {
+    return serviceDispatchIn(s, 212, program_index,
+        .out_num_objects = 1,
+        .out_objects = &out->s,
+    );
+}
 
-    return serviceDispatchIn(s, 7, in,
+Result fsOpenDataStorageByPathForBatchReadFwd(Service* s, FsStorageForBatchRead* out, const char* contentPath, FsContentAttributes attributes, FsFileSystemType fsType) {
+    const struct {
+        u8 attributes;
+        u8 pad[3];
+        u32 fsType;
+    } in = { attributes, {0}, fsType };
+
+    return serviceDispatchIn(s, 213, in,
+        .buffer_attrs = { SfBufferAttr_In | SfBufferAttr_HipcPointer | SfBufferAttr_FixedSize },
+        .buffers = { { contentPath, FS_MAX_PATH } },
         .out_num_objects = 1,
         .out_objects = &out->s
     );
 }
 
-Result fsOpenFileSystemWithIdFwd(Service* s, FsFileSystem* out, u64 id, FsFileSystemType fsType, const char* contentPath) {
-    const struct {
-        u32 fsType;
-        u64 id;
-    } in = { fsType, id };
-
-    return serviceDispatchIn(s, 8, in,
-        .buffer_attrs = { SfBufferAttr_HipcPointer | SfBufferAttr_In },
-        .buffers = { { contentPath, FS_MAX_PATH } },
-        .out_num_objects = 1,
-        .out_objects = &out->s
+Result fsRegisterProgramIndexMapInfoFwd(Service* s, const void *buf, size_t buf_size, s32 count) {
+    return serviceDispatchIn(s, 810, count,
+        .buffer_attrs = { SfBufferAttr_In | SfBufferAttr_HipcMapAlias },
+        .buffers = { { buf, buf_size } },
     );
-}
+}

stratosphere/ams_mitm/source/fs_mitm/fs_shim.h

@@ -12,18 +12,26 @@ extern "C" {
 #endif
 
 /* Missing fsp-srv commands. */
-Result fsOpenSdCardFileSystemFwd(Service* s, FsFileSystem* out);
+Result fsOpenFileSystemWithPatchFwd(Service* s, FsFileSystem* out, u64 id, FsFileSystemType fsType);
+Result fsOpenFileSystemWithIdObsoleteFwd(Service* s, FsFileSystem* out, const char* contentPath, u64 id, FsFileSystemType fsType);
+Result fsOpenFileSystemWithIdFwd(Service* s, FsFileSystem* out, const char* contentPath, FsContentAttributes attributes, u64 id, FsFileSystemType fsType);
+
 Result fsOpenBisStorageFwd(Service* s, FsStorage* out, FsBisPartitionId partition_id);
-Result fsOpenDataStorageByCurrentProcessFwd(Service* s, FsStorage* out);
-Result fsOpenDataStorageByDataIdFwd(Service* s, FsStorage* out, u64 data_id, NcmStorageId storage_id);
-Result fsOpenDataStorageWithProgramIndexFwd(Service* s, FsStorage* out, u8 program_index);
-
-Result fsRegisterProgramIndexMapInfoFwd(Service* s, const void *buf, size_t buf_size, s32 count);
-
+Result fsOpenSdCardFileSystemFwd(Service* s, FsFileSystem* out);
 Result fsOpenSaveDataFileSystemFwd(Service* s, FsFileSystem* out, FsSaveDataSpaceId save_data_space_id, const FsSaveDataAttribute *attr);
 
-Result fsOpenFileSystemWithPatchFwd(Service* s, FsFileSystem* out, u64 id, FsFileSystemType fsType);
-Result fsOpenFileSystemWithIdFwd(Service* s, FsFileSystem* out, u64 id, FsFileSystemType fsType, const char* contentPath);
+Result fsOpenDataStorageByCurrentProcessFwd(Service* s, FsStorage* out);
+Result fsOpenDataStorageByProgramIdFwd(Service* s, FsStorage* out, u64 id);
+Result fsOpenDataStorageByDataIdFwd(Service* s, FsStorage* out, u64 data_id, NcmStorageId storage_id);
+Result fsOpenDataStorageWithProgramIndexFwd(Service* s, FsStorage* out, u8 program_index);
+Result fsOpenDataStorageByPathFwd(Service* s, FsStorage* out, const char* contentPath, FsContentAttributes attributes, FsFileSystemType fsType);
+
+Result fsOpenDataStorageByCurrentProcessForBatchReadFwd(Service* s, FsStorageForBatchRead* out);
+Result fsOpenDataStorageByProgramIdForBatchReadFwd(Service* s, FsStorageForBatchRead* out, u64 id);
+Result fsOpenDataStorageWithProgramIndexForBatchReadFwd(Service* s, FsStorageForBatchRead* out, u8 program_index);
+Result fsOpenDataStorageByPathForBatchReadFwd(Service* s, FsStorageForBatchRead* out, const char* contentPath, FsContentAttributes attributes, FsFileSystemType fsType);
+
+Result fsRegisterProgramIndexMapInfoFwd(Service* s, const void *buf, size_t buf_size, s32 count);
 
 
 #ifdef __cplusplus

stratosphere/ams_mitm/source/fs_mitm/fsmitm_layered_romfs_storage.cpp

@@ -180,33 +180,79 @@ namespace ams::mitm::fs {
                     CloseReference(m_impl);
                 }
 
-
                 virtual Result Read(s64 offset, void *buffer, size_t size) override {
                     R_RETURN(m_impl->Read(offset, buffer, size));
                 }
-
+                
+                virtual Result Write(s64 offset, const void *buffer, size_t size) override {
+                    /* TODO: Better result code? */
+                    AMS_UNUSED(offset, buffer, size);
+                    R_THROW(ams::fs::ResultUnsupportedOperation())
+                }
+                
+                virtual Result Flush() override {
+                    R_RETURN(m_impl->Flush());
+                }
+                
+                virtual Result SetSize(s64 size) override {
+                    /* TODO: Better result code? */
+                    AMS_UNUSED(size);
+                    R_THROW(ams::fs::ResultUnsupportedOperation())
+                }
+                
                 virtual Result GetSize(s64 *out_size) override {
                     R_RETURN(m_impl->GetSize(out_size));
                 }
 
+                virtual Result OperateRange(void *dst, size_t dst_size, ams::fs::OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override {
+                    R_RETURN(m_impl->OperateRange(dst, dst_size, op_id, offset, size, src, src_size));
+                }
+        };
+        
+        class LayeredRomfsStorageForBatchRead : public ams::fs::IStorageForBatchRead {
+            private:
+                LayeredRomfsStorageImpl *m_impl;
+            public:
+                LayeredRomfsStorageForBatchRead(LayeredRomfsStorageImpl *impl) : m_impl(impl) {
+                    OpenReference(m_impl);
+                }
+
+                virtual ~LayeredRomfsStorageForBatchRead() {
+                    CloseReference(m_impl);
+                }
+                
+                virtual Result Read(s64 offset, void *buffer, size_t size) override {
+                    R_RETURN(m_impl->Read(offset, buffer, size));
+                }
+                
+                virtual Result Write(s64 offset, const void *buffer, size_t size) override {
+                    /* TODO: Better result code? */
+                    AMS_UNUSED(offset, buffer, size);
+                    R_THROW(ams::fs::ResultUnsupportedOperation())
+                }
+                
                 virtual Result Flush() override {
                     R_RETURN(m_impl->Flush());
                 }
+                
+                virtual Result SetSize(s64 size) override {
+                    /* TODO: Better result code? */
+                    AMS_UNUSED(size);
+                    R_THROW(ams::fs::ResultUnsupportedOperation())
+                }
+                
+                virtual Result GetSize(s64 *out_size) override {
+                    R_RETURN(m_impl->GetSize(out_size));
+                }
 
                 virtual Result OperateRange(void *dst, size_t dst_size, ams::fs::OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) override {
                     R_RETURN(m_impl->OperateRange(dst, dst_size, op_id, offset, size, src, src_size));
                 }
 
-                virtual Result Write(s64 offset, const void *buffer, size_t size) override {
-                    /* TODO: Better result code? */
-                    AMS_UNUSED(offset, buffer, size);
-                    R_THROW(ams::fs::ResultUnsupportedOperation())
-                }
-
-                virtual Result SetSize(s64 size) override {
-                    /* TODO: Better result code? */
-                    AMS_UNUSED(size);
-                    R_THROW(ams::fs::ResultUnsupportedOperation())
+                virtual Result BatchRead(void *out0, void *out1, void *out2, void *out3, void *out4, void *out5, void *out6, const void *in) override {
+                    /* TODO */
+                    AMS_UNUSED(out0, out1, out2, out3, out4, out5, out6, in);
+                    R_THROW(ams::fs::ResultUnsupportedOperation());
                 }
         };
 
@@ -261,6 +307,54 @@ namespace ams::mitm::fs {
         /* Return a new shared storage for the impl. */
         return std::make_shared<LayeredRomfsStorage>(impl);
     }
+    
+    std::shared_ptr<ams::fs::IStorageForBatchRead> GetLayeredRomfsStorageForBatchRead(ncm::ProgramId program_id, ::FsStorageForBatchRead &data_storage, bool is_process_romfs) {
+        /*Prepare to find or create a new storage. */
+        LayeredRomfsStorageImpl *impl = nullptr;
+        {
+            std::scoped_lock lk(g_storage_set_mutex);
+
+            /* Find an existing storage. */
+            if (auto it = g_storage_set.find_key(program_id.value); it != g_storage_set.end()) {
+                return std::make_shared<LayeredRomfsStorageForBatchRead>(it->GetImpl());
+            }
+
+            /* We don't have an existing storage. If we're creating process romfs, free any unreferenced process romfs. */
+            /* This should help prevent too much memory in use at any time. */
+            if (is_process_romfs) {
+                auto it = g_storage_set.begin();
+                while (it != g_storage_set.end()) {
+                    if (it->GetReferenceCount() > 0 || !it->IsProcessRomfs()) {
+                        ++it;
+                    } else {
+                        auto *holder = std::addressof(*it);
+                        it = g_storage_set.erase(it);
+                        delete holder;
+                    }
+                }
+            }
+
+            /* Create a new storage. */
+            {
+                ::FsFile data_file;
+                if (R_SUCCEEDED(OpenAtmosphereSdFile(std::addressof(data_file), program_id, "romfs.bin", OpenMode_Read))) {
+                    impl = new LayeredRomfsStorageImpl(std::make_unique<ReadOnlyStorageAdapterForBatchRead>(new RemoteStorageForBatchRead(data_storage)), std::make_unique<ReadOnlyStorageAdapterForBatchRead>(new FileStorage(new RemoteFile(data_file))), program_id);
+                } else {
+                    impl = new LayeredRomfsStorageImpl(std::make_unique<ReadOnlyStorageAdapterForBatchRead>(new RemoteStorageForBatchRead(data_storage)), nullptr, program_id);
+                }
+            }
+
+            /* Insert holder. Reference count will now be one. */
+            g_storage_set.insert(*(new LayeredRomfsStorageHolder(impl, is_process_romfs)));
+        }
+
+        /* Begin initialization. When this finishes, a decref will occur. */
+        AMS_ABORT_UNLESS(impl != nullptr);
+        impl->BeginInitialize();
+
+        /* Return a new shared storage for the impl. */
+        return std::make_shared<LayeredRomfsStorageForBatchRead>(impl);
+    }
 
     void FinalizeLayeredRomfsStorage(ncm::ProgramId program_id) {
         std::scoped_lock lk(g_initialization_mutex);
@@ -392,6 +486,10 @@ namespace ams::mitm::fs {
 
         R_SUCCEED();
     }
+    
+    Result LayeredRomfsStorageImpl::Flush() {
+        R_SUCCEED();
+    }
 
     Result LayeredRomfsStorageImpl::GetSize(s64 *out_size) {
         /* Ensure we're initialized. */
@@ -403,10 +501,6 @@ namespace ams::mitm::fs {
         R_SUCCEED();
     }
 
-    Result LayeredRomfsStorageImpl::Flush() {
-        R_SUCCEED();
-    }
-
     Result LayeredRomfsStorageImpl::OperateRange(void *dst, size_t dst_size, OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size) {
         AMS_UNUSED(offset, src, src_size);
 

stratosphere/ams_mitm/source/fs_mitm/fsmitm_layered_romfs_storage.hpp

@@ -44,13 +44,13 @@ namespace ams::mitm::fs {
             constexpr ncm::ProgramId GetProgramId() const { return m_program_id; }
 
             Result Read(s64 offset, void *buffer, size_t size);
-            Result GetSize(s64 *out_size);
             Result Flush();
+            Result GetSize(s64 *out_size);
             Result OperateRange(void *dst, size_t dst_size, ams::fs::OperationId op_id, s64 offset, s64 size, const void *src, size_t src_size);
     };
 
     std::shared_ptr<ams::fs::IStorage> GetLayeredRomfsStorage(ncm::ProgramId program_id, ::FsStorage &data_storage, bool is_process_romfs);
-
+    std::shared_ptr<ams::fs::IStorageForBatchRead> GetLayeredRomfsStorageForBatchRead(ncm::ProgramId program_id, ::FsStorageForBatchRead &data_storage, bool is_process_romfs);
     void FinalizeLayeredRomfsStorage(ncm::ProgramId program_id);
 
 }

stratosphere/ams_mitm/source/fs_mitm/fsmitm_romfs.cpp

@@ -51,6 +51,11 @@ namespace ams::mitm::fs {
                 /* Unknown heap sensitivity. */
                 { 0x01002C9022770000,  16_MB, 0_MB },
 
+                /* Trails in the Sky 2nd Chapter. */
+                /* Requirement ~16 MB.*/
+                /* No particular heap sensitivity. */
+                { 0x01007A2027548000,  8_MB, 0_MB },
+
                 /* STAR WARS: Knights of the Old Republic II: The Sith Lords. */
                 /* Requirement ? MB. 16 MB stolen heap fixes a crash, though. */
                 /* Unknown heap sensitivity. */
@@ -469,7 +474,7 @@ namespace ams::mitm::fs {
                         return entry;
                     }
             };
-
+            
             template<typename Entry>
             class TableWriter : public DynamicTableCache {
                 NON_COPYABLE(TableWriter);
@@ -722,12 +727,12 @@ namespace ams::mitm::fs {
             public:
                 DirectoryTableReader(ams::fs::IStorage *s, size_t ofs, size_t sz) : TableReader(s, ofs, sz) { /* ... */ }
         };
-
+        
         class FileTableReader : public TableReader<FileEntry> {
             public:
                 FileTableReader(ams::fs::IStorage *s, size_t ofs, size_t sz) : TableReader(s, ofs, sz) { /* ... */ }
         };
-
+        
         void Builder::VisitDirectory(BuildDirectoryContext *parent, u32 parent_offset, DirectoryTableReader &dir_table, FileTableReader &file_table) {
             const DirectoryEntry *parent_entry = dir_table.GetEntry(parent_offset);
             if (AMS_UNLIKELY(parent_entry == nullptr)) {
@@ -768,8 +773,7 @@ namespace ams::mitm::fs {
                 cur_child_offset = next_child_offset;
             }
         }
-
-
+        
         void Builder::AddSdFiles() {
             /* Open Sd Card filesystem. */
             FsFileSystem sd_filesystem;

stratosphere/ams_mitm/source/fs_mitm/fsmitm_romfs.hpp

@@ -361,7 +361,7 @@ namespace ams::mitm::fs::romfs {
         private:
             void VisitDirectory(FsFileSystem *fs, BuildDirectoryContext *parent);
             void VisitDirectory(BuildDirectoryContext *parent, u32 parent_offset, DirectoryTableReader &dir_table, FileTableReader &file_table);
-
+            
             void AddDirectory(BuildDirectoryContext **out, BuildDirectoryContext *parent_ctx, std::unique_ptr<BuildDirectoryContext> file_ctx);
             void AddFile(BuildDirectoryContext *parent_ctx, std::unique_ptr<BuildFileContext> file_ctx);
         public:

troposphere/daybreak/source/ui.cpp

@@ -49,7 +49,6 @@ namespace dbk {
         u32 g_screen_height;
 
         constinit u32 g_supported_version = std::numeric_limits<u32>::max();
-        constinit bool g_hos_version_check_enabled = true;
 
         std::shared_ptr<Menu> g_current_menu;
         bool g_initialized = false;
@@ -142,35 +141,8 @@ namespace dbk {
             return rc;
         }
 
-        u32 EncodeVersion(u32 major, u32 minor, u32 micro) {
-            return ((major & 0xFF) << 24) | ((minor & 0xFF) << 16) | ((micro & 0xFF) << 8);
-        }
-
-        u32 NcmVersionToHosVersion(u32 ncm_version) {
-            const u32 major = (ncm_version >> 26) & 0x1f;
-            const u32 minor = (ncm_version >> 20) & 0x1f;
-            const u32 micro = (ncm_version >> 16) & 0xf;
-            return EncodeVersion(major, minor, micro);
-        }
-
-        bool IsHosVersionSupported(u32 hos_version) {
-            if (!g_hos_version_check_enabled) {
-                return true;
-            }
-
-            return hos_version <= g_supported_version;
-        }
-
-        std::shared_ptr<Menu> CreateUpdateMenuAfterPathSelection(std::shared_ptr<Menu> prev_menu) {
-            AmsSuUpdateInformation update_info = {};
-            if (R_SUCCEEDED(amssuGetUpdateInformation(&update_info, g_update_path))) {
-                const u32 update_hos_version = NcmVersionToHosVersion(update_info.version);
-                if (!IsHosVersionSupported(update_hos_version)) {
-                    return std::make_shared<FirmwareNotSupportedMenu>(prev_menu, update_info.version, g_supported_version);
-                }
-            }
-
-            return std::make_shared<ValidateUpdateMenu>(prev_menu);
+        u32 EncodeVersion(u32 major, u32 minor, u32 micro, u32 relstep = 0) {
+            return ((major & 0xFF) << 24) | ((minor & 0xFF) << 16) | ((micro & 0xFF) << 8) | ((relstep & 0xFF) << 8);
         }
 
     }
@@ -474,78 +446,12 @@ namespace dbk {
         }
     }
 
-    namespace {
-
-        struct FirmwareNotSupportedSubtext {
-            char value[0x100];
-
-            FirmwareNotSupportedSubtext(u32 update_ncm_version, u32 max_supported_hos_version) {
-                snprintf(this->value, sizeof(this->value),
-                    "Maximal unterstützte Firmware ist %u.%u.%u.\n"
-                    "Aktualisiere Atmosphere, bevor du diese Firmware installierst.",
-                    (max_supported_hos_version >> 24) & 0xff, (max_supported_hos_version >> 16) & 0xff, (max_supported_hos_version >> 8) & 0xff);
-            }
-
-            operator const char *() const {
-                return this->value;
-            }
-        };
-
-    }
-
-    FirmwareNotSupportedMenu::FirmwareNotSupportedMenu(std::shared_ptr<Menu> prev_menu, u32 update_ncm_version, u32 max_supported_hos_version)
-        : AlertMenu(prev_menu, "Nicht unterstützte Firmware-Version", FirmwareNotSupportedSubtext(update_ncm_version, max_supported_hos_version), 0) {
-        const float window_height = WindowHeight + SubTextAreaHeight;
-        const float x = g_screen_width / 2.0f - WindowWidth / 2.0f;
-        const float y = g_screen_height / 2.0f - window_height / 2.0f;
-        const float button_y = y + TitleGap + SubTextAreaHeight + VerticalGap * 2.0f;
-        const float button_width = WindowWidth - HorizontalInset * 2.0f;
-
-        this->AddButton(BackButtonId, "Zurück", x + HorizontalInset, button_y, button_width, ButtonHeight);
-        this->SetButtonSelected(BackButtonId, true);
-    }
-
-    void FirmwareNotSupportedMenu::Draw(NVGcontext *vg, u64 ns) {
-        const float window_height = WindowHeight + SubTextAreaHeight;
-        const float x = g_screen_width / 2.0f - WindowWidth / 2.0f;
-        const float y = g_screen_height / 2.0f - window_height / 2.0f;
-
-        DrawWindow(vg, m_text, x, y, WindowWidth, window_height);
-        DrawTextBlock(vg, m_subtext, x + HorizontalInset, y + TitleGap, WindowWidth - HorizontalInset * 2.0f, SubTextAreaHeight);
-        this->DrawButtons(vg, ns);
-    }
-
-    void FirmwareNotSupportedMenu::Update(u64 ns) {
-        u64 k_down = padGetButtonsDown(&g_pad);
-
-        if (k_down & HidNpadButton_B) {
-            ReturnToPreviousMenu();
-            return;
-        }
-
-        if (const Button *activated_button = this->GetActivatedButton(); activated_button != nullptr) {
-            if (activated_button->id == BackButtonId) {
-                ReturnToPreviousMenu();
-                return;
-            }
-        }
-
-        this->UpdateButtons();
-
-        if (const Button *selected_button = this->GetSelectedButton(); k_down && selected_button == nullptr) {
-            this->SetButtonSelected(BackButtonId, true);
-        }
-    }
-
     MainMenu::MainMenu() : Menu(nullptr) {
         const float x = g_screen_width / 2.0f - WindowWidth / 2.0f;
         const float y = g_screen_height / 2.0f - WindowHeight / 2.0f;
 
-        const float button_x = x + HorizontalInset;
-        const float button_w = WindowWidth - HorizontalInset * 2;
-        this->AddButton(InstallButtonId, "Installieren", button_x, y + TitleGap, button_w, ButtonHeight);
-        this->AddButton(SettingsButtonId, "Einstellungen", button_x, y + TitleGap + ButtonHeight + VerticalGap, button_w, ButtonHeight);
-        this->AddButton(ExitButtonId, "Beenden", button_x, y + TitleGap + (ButtonHeight + VerticalGap) * 2, button_w, ButtonHeight);
+        this->AddButton(InstallButtonId, "Installieren", x + HorizontalInset, y + TitleGap, WindowWidth - HorizontalInset * 2, ButtonHeight);
+        this->AddButton(ExitButtonId, "Beenden", x + HorizontalInset, y + TitleGap + ButtonHeight + VerticalGap, WindowWidth - HorizontalInset * 2, ButtonHeight);
         this->SetButtonSelected(InstallButtonId, true);
     }
 
@@ -593,9 +499,6 @@ namespace dbk {
 
                     return;
                 }
-                case SettingsButtonId:
-                    ChangeMenu(std::make_shared<SettingsMenu>(g_current_menu));
-                    return;
                 case ExitButtonId:
                     g_exit_requested = true;
                     return;
@@ -615,87 +518,6 @@ namespace dbk {
         this->DrawButtons(vg, ns);
     }
 
-    SettingsMenu::SettingsMenu(std::shared_ptr<Menu> prev_menu) : Menu(prev_menu) {
-        const float x = g_screen_width / 2.0f - WindowWidth / 2.0f;
-        const float y = g_screen_height / 2.0f - WindowHeight / 2.0f;
-        const float button_x = x + HorizontalInset;
-        const float button_w = WindowWidth - HorizontalInset * 2.0f;
-
-        this->AddButton(VersionCheckButtonId, "Firmware-Prüfung", button_x, y + TitleGap, button_w, ButtonHeight);
-        this->AddButton(BackButtonId, "Zurück", button_x, y + WindowHeight - BottomInset - ButtonHeight, button_w, ButtonHeight);
-        this->SetButtonSelected(VersionCheckButtonId, true);
-    }
-
-    void SettingsMenu::Update(u64 ns) {
-        const u64 k_down = padGetButtonsDown(&g_pad);
-
-        if (k_down & HidNpadButton_B) {
-            ReturnToPreviousMenu();
-            return;
-        }
-
-        if (const Button *activated_button = this->GetActivatedButton(); activated_button != nullptr) {
-            switch (activated_button->id) {
-                case VersionCheckButtonId:
-                    g_hos_version_check_enabled = !g_hos_version_check_enabled;
-                    break;
-                case BackButtonId:
-                    ReturnToPreviousMenu();
-                    return;
-            }
-        }
-
-        this->UpdateButtons();
-
-        if (const Button *selected_button = this->GetSelectedButton(); k_down && selected_button == nullptr) {
-            this->SetButtonSelected(VersionCheckButtonId, true);
-        }
-    }
-
-    void SettingsMenu::Draw(NVGcontext *vg, u64 ns) {
-        const float x = g_screen_width / 2.0f - WindowWidth / 2.0f;
-        const float y = g_screen_height / 2.0f - WindowHeight / 2.0f;
-
-        DrawWindow(vg, "Einstellungen", x, y, WindowWidth, WindowHeight);
-
-        if (const Button *toggle = this->GetButton(VersionCheckButtonId); toggle != nullptr) {
-            const ButtonStyle style = toggle->selected ? ButtonStyle::StandardSelected : ButtonStyle::Standard;
-            DrawButton(vg, "", toggle->x, toggle->y, toggle->w, toggle->h, style, ns);
-
-            nvgFontSize(vg, 20.0f);
-            nvgFontFace(vg, "switch-standard");
-            nvgTextAlign(vg, NVG_ALIGN_LEFT | NVG_ALIGN_MIDDLE);
-            nvgFillColor(vg, toggle->selected ? nvgRGB(255, 255, 255) : nvgRGB(0, 0, 0));
-            nvgText(vg, toggle->x + 16.0f, toggle->y + toggle->h * 0.5f, "Firmware-Prüfung", nullptr);
-
-            constexpr float ToggleWidth = 64.0f;
-            constexpr float ToggleHeight = 32.0f;
-            DrawToggle(vg,
-                toggle->x + toggle->w - 16.0f - ToggleWidth,
-                toggle->y + (toggle->h - ToggleHeight) * 0.5f,
-                ToggleWidth,
-                ToggleHeight,
-                g_hos_version_check_enabled,
-                toggle->selected);
-        }
-
-        char hint[64];
-        const unsigned major = (g_supported_version >> 24) & 0xff;
-        const unsigned minor = (g_supported_version >> 16) & 0xff;
-        const unsigned micro = (g_supported_version >> 8) & 0xff;
-        if (g_hos_version_check_enabled) {
-            snprintf(hint, sizeof(hint), "Firmware <= %u.%u.%u", major, minor, micro);
-        } else {
-            snprintf(hint, sizeof(hint), "Auch Firmware > %u.%u.%u", major, minor, micro);
-        }
-        DrawText(vg, x + HorizontalInset, y + TitleGap + ButtonHeight + VerticalGap + 8.0f, WindowWidth - HorizontalInset * 2.0f, hint);
-
-        if (const Button *back = this->GetButton(BackButtonId); back != nullptr) {
-            const ButtonStyle style = back->selected ? ButtonStyle::StandardSelected : ButtonStyle::Standard;
-            DrawButton(vg, "Zurück", back->x, back->y, back->w, back->h, style, ns);
-        }
-    }
-
     FileMenu::FileMenu(std::shared_ptr<Menu> prev_menu, const char *root) : Menu(prev_menu), m_current_index(0), m_scroll_offset(0), m_touch_start_scroll_offset(0), m_touch_finalize_selection(false) {
         Result rc = 0;
 
@@ -866,7 +688,7 @@ namespace dbk {
             snprintf(g_update_path, sizeof(g_update_path), "%s", current_path);
 
             /* Change the menu. */
-            ChangeMenu(CreateUpdateMenuAfterPathSelection(g_current_menu));
+            ChangeMenu(std::make_shared<ValidateUpdateMenu>(g_current_menu));
         } else {
             ChangeMenu(std::make_shared<FileMenu>(g_current_menu, current_path));
         }
@@ -974,7 +796,6 @@ namespace dbk {
 
         /* Print update information. */
         this->LogText("- Version: %d.%d.%d\n", (m_update_info.version >> 26) & 0x1f, (m_update_info.version >> 20) & 0x1f, (m_update_info.version >> 16) & 0xf);
-        this->LogText("- Von Atmosphere max. unterstützt: %d.%d.%d\n", (g_supported_version >> 24) & 0xff, (g_supported_version >> 16) & 0xff, (g_supported_version >> 8) & 0xff);
         if (m_update_info.exfat_supported) {
             this->LogText("- exFAT: Unterstützt\n");
         } else {
@@ -1079,6 +900,12 @@ namespace dbk {
                         next_menu = std::make_shared<WarningMenu>(g_current_menu, next_menu, "Warnung: exFAT-Firmware fehlt oder ist beschädigt", "Möchtest du wirklich fortfahren?");
                     }
 
+                    /* Warn the user if they're updating to a version higher than supported. */
+                    const u32 version = m_validation_info.invalid_key.version;
+                    if (EncodeVersion((version >> 26) & 0x1f, (version >> 20) & 0x1f, (version >> 16) & 0xf) > g_supported_version) {
+                        next_menu = std::make_shared<WarningMenu>(g_current_menu, next_menu, "Warnung: Firmware ist zu neu und nicht als unterstützt bekannt", "Möchtest du wirklich fortfahren?");
+                    }
+
                     /* Change to the next menu. */
                     ChangeMenu(next_menu);
                     return;
@@ -1168,8 +995,8 @@ namespace dbk {
         const float button_width = (WindowWidth - HorizontalInset * 2.0f) / 2.0f - ButtonHorizontalGap;
 
         /* Add buttons. */
-        this->AddButton(Fat32ButtonId, "Install (FAT32)", x + HorizontalInset, y + TitleGap, button_width, ButtonHeight);
-        this->AddButton(ExFatButtonId, "Install (FAT32 + exFAT)", x + HorizontalInset + button_width + ButtonHorizontalGap, y + TitleGap, button_width, ButtonHeight);
+        this->AddButton(Fat32ButtonId, "Installieren (FAT32)", x + HorizontalInset, y + TitleGap, button_width, ButtonHeight);
+        this->AddButton(ExFatButtonId, "Installieren (FAT32 + exFAT)", x + HorizontalInset + button_width + ButtonHorizontalGap, y + TitleGap, button_width, ButtonHeight);
 
         /* Set the default selected button based on the user's current install. We aren't particularly concerned if fsIsExFatSupported fails. */
         bool exfat_supported = false;
@@ -1430,12 +1257,10 @@ namespace dbk {
             return false;
         }
 
-        /* Get the maximum HOS version supported by this Atmosphere build (hos::Version_Max). */
-        if (R_FAILED(rc = splGetConfig(static_cast<SplConfigItem>(ExosphereSupportedHosVersion), &version))) {
-            ChangeMenu(std::make_shared<ErrorMenu>("Atmosphere nicht gefunden", "Maximal unterstützte Firmware-Version konnte nicht ermittelt werden.", rc));
-            return false;
+        /* Attempt to get the supported version. */
+        if (R_SUCCEEDED(rc = splGetConfig(static_cast<SplConfigItem>(ExosphereSupportedHosVersion), &version))) {
+            g_supported_version = static_cast<u32>(version);
         }
-        g_supported_version = static_cast<u32>(version);
 
         /* Initialize ams:su. */
         if (R_FAILED(rc = amssuInitialize())) {
@@ -1455,7 +1280,7 @@ namespace dbk {
             strncpy(g_update_path, update_path, sizeof(g_update_path)-1);
 
             /* Change the menu. */
-            ChangeMenu(CreateUpdateMenuAfterPathSelection(g_current_menu));
+            ChangeMenu(std::make_shared<ValidateUpdateMenu>(g_current_menu));
 
             return true;
         }

troposphere/daybreak/source/ui.hpp

@@ -120,25 +120,13 @@ namespace dbk {
             virtual void Update(u64 ns) override;
     };
 
-    class FirmwareNotSupportedMenu : public AlertMenu {
-        private:
-            static constexpr u32 BackButtonId = 0;
-            static constexpr float SubTextAreaHeight = 72.0f;
-        public:
-            FirmwareNotSupportedMenu(std::shared_ptr<Menu> prev_menu, u32 update_ncm_version, u32 max_supported_hos_version);
-
-            virtual void Update(u64 ns) override;
-            virtual void Draw(NVGcontext *vg, u64 ns) override;
-    };
-
     class MainMenu : public Menu {
         private:
-            static constexpr u32 InstallButtonId  = 0;
-            static constexpr u32 SettingsButtonId = 1;
-            static constexpr u32 ExitButtonId     = 2;
+            static constexpr u32 InstallButtonId = 0;
+            static constexpr u32 ExitButtonId    = 1;
 
             static constexpr float WindowWidth             = 400.0f;
-            static constexpr float WindowHeight            = 310.0f;
+            static constexpr float WindowHeight            = 240.0f;
             static constexpr float TitleGap                = 90.0f;
         public:
             MainMenu();
@@ -147,21 +135,6 @@ namespace dbk {
             virtual void Draw(NVGcontext *vg, u64 ns) override;
     };
 
-    class SettingsMenu : public Menu {
-        private:
-            static constexpr u32 VersionCheckButtonId = 0;
-            static constexpr u32 BackButtonId         = 1;
-
-            static constexpr float WindowWidth  = 560.0f;
-            static constexpr float WindowHeight = 300.0f;
-            static constexpr float TitleGap     = 90.0f;
-        public:
-            SettingsMenu(std::shared_ptr<Menu> prev_menu);
-
-            virtual void Update(u64 ns) override;
-            virtual void Draw(NVGcontext *vg, u64 ns) override;
-    };
-
     class FileMenu : public Menu {
         private:
             struct FileEntry {

troposphere/daybreak/source/ui_util.cpp

@@ -129,27 +129,6 @@ namespace dbk {
         }
     }
 
-    void DrawToggle(NVGcontext *vg, float x, float y, float w, float h, bool on, bool selected) {
-        const float radius = h * 0.5f;
-
-        nvgBeginPath(vg);
-        nvgRoundedRect(vg, x, y, w, h, radius);
-        if (on) {
-            nvgFillColor(vg, selected ? nvgRGB(255, 255, 255) : nvgRGB(83, 71, 185));
-        } else {
-            nvgFillColor(vg, selected ? nvgRGBA(255, 255, 255, 80) : nvgRGBA(0, 0, 0, 48));
-        }
-        nvgFill(vg);
-
-        const float pad = 3.0f;
-        const float knob = h - pad * 2.0f;
-        const float knob_x = on ? (x + w - pad - knob) : (x + pad);
-        nvgBeginPath(vg);
-        nvgRoundedRect(vg, knob_x, y + pad, knob, knob, knob * 0.5f);
-        nvgFillColor(vg, on && selected ? nvgRGB(83, 71, 185) : nvgRGB(255, 255, 255));
-        nvgFill(vg);
-    }
-
     void DrawTextBackground(NVGcontext *vg, float x, float y, float w, float h) {
         nvgBeginPath(vg);
         nvgRoundedRect(vg, x, y, w, h, TextAreaCornerRadius);

troposphere/daybreak/source/ui_util.hpp

@@ -31,7 +31,6 @@ namespace dbk {
     void DrawBackground(NVGcontext *vg, float w, float h);
     void DrawWindow(NVGcontext *vg, const char *title, float x, float y, float w, float h);
     void DrawButton(NVGcontext *vg, const char *text, float x, float y, float w, float h, ButtonStyle style, u64 ns);
-    void DrawToggle(NVGcontext *vg, float x, float y, float w, float h, bool on, bool selected);
     void DrawTextBackground(NVGcontext *vg, float x, float y, float w, float h);
     void DrawText(NVGcontext *vg, float x, float y, float w, const char *text);
     void DrawProgressText(NVGcontext *vg, float x, float y, float progress);