From 9050229b12e28587a8300115d08be7e09db3c399 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=AD=90=EF=B8=8FNINIKA=E2=AD=90=EF=B8=8F?=
 <DCNick3@users.noreply.github.com>
Date: Tue, 27 May 2025 19:05:28 +0300
Subject: [PATCH] Change NSP padding logic to follow nxdt and nsfw validation
 (#147)

---
 sphaira/source/yati/container/nsp.cpp | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/sphaira/source/yati/container/nsp.cpp b/sphaira/source/yati/container/nsp.cpp
index 2a52ba5..ab2196b 100644
--- a/sphaira/source/yati/container/nsp.cpp
+++ b/sphaira/source/yati/container/nsp.cpp
@@ -112,9 +112,17 @@ auto Nsp::Build(std::span<CollectionEntry> entries, s64& size) -> std::vector<u8
         string_offset += entries[i].name.length() + 1;
     }
 
-    // align table
-    string_table.resize((string_table.size() + 0x1F) & ~0x1F);
+    // Add padding to the string table so that the header as a whole is well-aligned
+    const auto nameless_header_size = sizeof(Pfs0Header) + (file_table.size() * sizeof(Pfs0FileTableEntry));
+    auto padded_string_table_size = ((nameless_header_size + string_table.size() + 0x1F) & ~0x1F) - nameless_header_size;
 
+    // Add manual padding if the full Partition FS header would already be properly aligned.
+    if (padded_string_table_size == string_table.size()) {
+        padded_string_table_size += 0x20;
+    }
+    
+    string_table.resize(padded_string_table_size);
+    
     header.magic = PFS0_MAGIC;
     header.total_files = entries.size();
     header.string_table_size = string_table.size();