disable sftp as it was unused and very slow compared to other clients.

This commit is contained in:
ITotalJustice
2025-10-03 09:07:12 +01:00
parent ca5ea827b2
commit 81e6bc5833
2 changed files with 8 additions and 1 deletions

View File

@@ -26,7 +26,7 @@ option(ENABLE_DEVOPTAB_WEBDAV "" ON)
# max speed is 8MiB/s, which is fine for wifi, but awful for ethernet. # max speed is 8MiB/s, which is fine for wifi, but awful for ethernet.
# other clients get 36-40MiB/s. # other clients get 36-40MiB/s.
# it also adds 230k to binary size, and i don't think anyone will use it. # it also adds 230k to binary size, and i don't think anyone will use it.
option(ENABLE_DEVOPTAB_SFTP "" ON) option(ENABLE_DEVOPTAB_SFTP "" OFF)
set(sphaira_VERSION 0.13.3) set(sphaira_VERSION 0.13.3)

View File

@@ -25,10 +25,13 @@ namespace {
using namespace sphaira::ui; using namespace sphaira::ui;
using namespace sphaira::devoptab::common; using namespace sphaira::devoptab::common;
// todo: support for disabling some / all mounts.
enum class DevoptabType { enum class DevoptabType {
HTTP, HTTP,
FTP, FTP,
#ifdef ENABLE_DEVOPTAB_SFTP
SFTP, SFTP,
#endif
NFS, NFS,
SMB, SMB,
WEBDAV, WEBDAV,
@@ -44,7 +47,9 @@ struct TypeEntry {
const TypeEntry TYPE_ENTRIES[] = { const TypeEntry TYPE_ENTRIES[] = {
{"HTTP", "http://", 80, DevoptabType::HTTP}, {"HTTP", "http://", 80, DevoptabType::HTTP},
{"FTP", "ftp://", 21, DevoptabType::FTP}, {"FTP", "ftp://", 21, DevoptabType::FTP},
#ifdef ENABLE_DEVOPTAB_SFTP
{"SFTP", "sftp://", 22, DevoptabType::SFTP}, {"SFTP", "sftp://", 22, DevoptabType::SFTP},
#endif
{"NFS", "nfs://", 2049, DevoptabType::NFS}, {"NFS", "nfs://", 2049, DevoptabType::NFS},
{"SMB", "smb://", 445, DevoptabType::SMB}, {"SMB", "smb://", 445, DevoptabType::SMB},
{"WEBDAV", "webdav://", 80, DevoptabType::WEBDAV}, {"WEBDAV", "webdav://", 80, DevoptabType::WEBDAV},
@@ -60,7 +65,9 @@ auto BuildIniPathFromType(DevoptabType type) -> fs::FsPath {
switch (type) { switch (type) {
case DevoptabType::HTTP: return MOUNT_PATH "/http.ini"; case DevoptabType::HTTP: return MOUNT_PATH "/http.ini";
case DevoptabType::FTP: return MOUNT_PATH "/ftp.ini"; case DevoptabType::FTP: return MOUNT_PATH "/ftp.ini";
#ifdef ENABLE_DEVOPTAB_SFTP
case DevoptabType::SFTP: return MOUNT_PATH "/sftp.ini"; case DevoptabType::SFTP: return MOUNT_PATH "/sftp.ini";
#endif
case DevoptabType::NFS: return MOUNT_PATH "/nfs.ini"; case DevoptabType::NFS: return MOUNT_PATH "/nfs.ini";
case DevoptabType::SMB: return MOUNT_PATH "/smb.ini"; case DevoptabType::SMB: return MOUNT_PATH "/smb.ini";
case DevoptabType::WEBDAV: return MOUNT_PATH "/webdav.ini"; case DevoptabType::WEBDAV: return MOUNT_PATH "/webdav.ini";