fix mtp install (again) due to the next transfer trying to start before the previous one had finished.

sphaira/include/ui/menus/install_stream_menu_base.hpp

@@ -34,8 +34,10 @@ private:
     fs::FsPath m_path{};
     std::stop_token m_token{};
     std::vector<u8> m_buffer{};
-    Mutex m_mutex{};
     CondVar m_can_read{};
+
+public:
+    Mutex m_mutex{};
     bool m_active{};
 };
 

sphaira/source/ui/menus/install_stream_menu_base.cpp

@@ -191,10 +191,45 @@ void Menu::Draw(NVGcontext* vg, Theme* theme) {
 
 bool Menu::OnInstallStart(const char* path) {
     log_write("[Menu::OnInstallStart] inside\n");
-    if (INSTALL_STATE == InstallState::Progress) {
-        log_write("[Menu::OnInstallStart] already in progress\n");
+
+    for (;;) {
+        {
+            SCOPED_MUTEX(&m_mutex);
+
+            if (m_state != State::Progress) {
+                break;
+            }
+
+            if (GetToken().stop_requested()) {
                 return false;
             }
+        }
+
+        svcSleepThread(1e+6);
+    }
+
+    log_write("[Menu::OnInstallStart] got state: %u\n", (u8)m_state);
+
+    if (m_source) {
+        log_write("[Menu::OnInstallStart] we have source\n");
+        for (;;) {
+            {
+                SCOPED_MUTEX(&m_source->m_mutex);
+
+                if (!m_source->m_active && INSTALL_STATE != InstallState::Progress) {
+                    break;
+                }
+
+                if (GetToken().stop_requested()) {
+                    return false;
+                }
+            }
+
+            svcSleepThread(1e+6);
+        }
+
+        log_write("[Menu::OnInstallStart] stopped polling source\n");
+    }
 
     SCOPED_MUTEX(&m_mutex);