From 70a31be134bf97566ac150ec3fae354e6d9e986a Mon Sep 17 00:00:00 2001 From: ITotalJustice <47043333+ITotalJustice@users.noreply.github.com> Date: Thu, 15 May 2025 15:25:03 +0100 Subject: [PATCH] don't fail if the control nca cannot be parsed during install, as it may depend on ticket not yet installed. --- sphaira/source/yati/yati.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sphaira/source/yati/yati.cpp b/sphaira/source/yati/yati.cpp index c1690d9..cc16f0e 100644 --- a/sphaira/source/yati/yati.cpp +++ b/sphaira/source/yati/yati.cpp @@ -929,8 +929,10 @@ Result Yati::InstallNca(std::span tickets, NcaCollection& nca) { } else if (nca.header.content_type == nca::ContentType_Control) { NacpLanguageEntry entry; std::vector icon; - R_TRY(nca::ParseControl(path, nca.header.program_id, &entry, sizeof(entry), &icon)); - pbox->SetTitle(entry.name).SetImageData(icon); + // this may fail if tickets aren't installed and the nca uses title key crypto. + if (R_SUCCEEDED(nca::ParseControl(path, nca.header.program_id, &entry, sizeof(entry), &icon))) { + pbox->SetTitle(entry.name).SetImageData(icon); + } } R_SUCCEED();