From 4bd776c8aa831eebdb2b9843cce23b039b679c11 Mon Sep 17 00:00:00 2001 From: Lightos1 <124387232+Lightos1@users.noreply.github.com> Date: Sun, 10 May 2026 18:58:37 +0200 Subject: [PATCH] kip.cpp: improve version mismatch logging --- Source/hoc-clk/sysmodule/src/file/kip.cpp | 28 ++++++++++++++++++----- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/Source/hoc-clk/sysmodule/src/file/kip.cpp b/Source/hoc-clk/sysmodule/src/file/kip.cpp index 9f3a9827..5a6aba02 100644 --- a/Source/hoc-clk/sysmodule/src/file/kip.cpp +++ b/Source/hoc-clk/sysmodule/src/file/kip.cpp @@ -53,9 +53,17 @@ namespace kip { return; } - if(cust_get_cust_rev(&table) != CUST_REV || cust_get_kip_version(&table) != KIP_VERSION) { - fileUtils::LogLine("Revision: %u", cust_get_cust_rev(&table)); - notification::writeNotification("Horizon OC\nKip version mismatch\nPlease reinstall Horizon OC"); + u32 custRev = cust_get_cust_rev(&table); + u32 kipVersion = cust_get_kip_version(&table) + if (custRev < CUST_REV || kipVersion < KIP_VERSION) { + notification::writeNotification("Horizon OC\nOutdated kip detected!\nPlease update Horizon OC"); + fileUtils::LogLine("Cust revision: %u", custRev); + fileUtils::LogLine("Kip version: %u", kipVersion); + return; + } else if (custRev > CUST_REV || kipVersion > KIP_VERSION) { + notification::writeNotification("Horizon OC\nOutdated sysmodule detected!\nPlease update Horizon OC"); + fileUtils::LogLine("Cust revision: %u", custRev); + fileUtils::LogLine("Kip version: %u", kipVersion); return; } @@ -201,9 +209,17 @@ namespace kip { // configValues.values[KipConfigValue_mtcConf] = cust_get_mtc_conf(&table); clockManager::gContext.custRev = cust_get_cust_rev(&table); - u16 kipVersion = cust_get_kip_version(&table); - if (kipVersion != KIP_VERSION || cust_get_cust_rev(&table) != CUST_REV) { - notification::writeNotification("Horizon OC\nKip version mismatch detected!"); + u32 custRev = cust_get_cust_rev(&table); + u32 kipVersion = cust_get_kip_version(&table) + if (custRev < CUST_REV || kipVersion < KIP_VERSION) { + notification::writeNotification("Horizon OC\nOutdated kip detected!\nPlease update Horizon OC"); + fileUtils::LogLine("Cust revision: %u", custRev); + fileUtils::LogLine("Kip version: %u", kipVersion); + return; + } else if (custRev > CUST_REV || kipVersion > KIP_VERSION) { + notification::writeNotification("Horizon OC\nOutdated sysmodule detected!\nPlease update Horizon OC"); + fileUtils::LogLine("Cust revision: %u", custRev); + fileUtils::LogLine("Kip version: %u", kipVersion); return; }