Use "final" and "override" where appropriate (#117)
This commit is contained in:
@@ -10,10 +10,10 @@ enum DebugMonitorServiceCmd {
|
||||
Dmnt_Cmd_GetNsoInfo = 2
|
||||
};
|
||||
|
||||
class DebugMonitorService : IServiceObject {
|
||||
class DebugMonitorService final : IServiceObject {
|
||||
public:
|
||||
virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
|
||||
virtual Result handle_deferred() {
|
||||
Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
|
||||
Result handle_deferred() override {
|
||||
/* This service will never defer. */
|
||||
return 0;
|
||||
}
|
||||
@@ -23,4 +23,4 @@ class DebugMonitorService : IServiceObject {
|
||||
std::tuple<Result> add_title_to_launch_queue(u64 tid, InPointer<char> args);
|
||||
std::tuple<Result> clear_launch_queue(u64 dat);
|
||||
std::tuple<Result, u32> get_nso_info(u64 pid, OutPointerWithClientSize<Registration::NsoInfo> out);
|
||||
};
|
||||
};
|
||||
|
||||
@@ -12,7 +12,7 @@ enum ProcessManagerServiceCmd {
|
||||
Pm_Cmd_UnregisterTitle = 3
|
||||
};
|
||||
|
||||
class ProcessManagerService : IServiceObject {
|
||||
class ProcessManagerService final : IServiceObject {
|
||||
struct ProgramInfo {
|
||||
u8 main_thread_priority;
|
||||
u8 default_cpu_id;
|
||||
@@ -29,8 +29,8 @@ class ProcessManagerService : IServiceObject {
|
||||
static_assert(sizeof(ProcessManagerService::ProgramInfo) == 0x400, "Incorrect ProgramInfo definition.");
|
||||
|
||||
public:
|
||||
virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
|
||||
virtual Result handle_deferred() {
|
||||
Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
|
||||
Result handle_deferred() override {
|
||||
/* This service will never defer. */
|
||||
return 0;
|
||||
}
|
||||
@@ -44,4 +44,4 @@ class ProcessManagerService : IServiceObject {
|
||||
|
||||
/* Utilities */
|
||||
Result populate_program_info_buffer(ProcessManagerService::ProgramInfo *out, Registration::TidSid *tid_sid);
|
||||
};
|
||||
};
|
||||
|
||||
@@ -12,7 +12,7 @@ enum RoServiceCmd {
|
||||
Ro_Cmd_Initialize = 4,
|
||||
};
|
||||
|
||||
class RelocatableObjectsService : IServiceObject {
|
||||
class RelocatableObjectsService final : IServiceObject {
|
||||
Handle process_handle;
|
||||
u64 process_id;
|
||||
bool has_initialized;
|
||||
@@ -24,8 +24,8 @@ class RelocatableObjectsService : IServiceObject {
|
||||
svcCloseHandle(this->process_handle);
|
||||
}
|
||||
}
|
||||
virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
|
||||
virtual Result handle_deferred() {
|
||||
Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
|
||||
Result handle_deferred() override {
|
||||
/* This service will never defer. */
|
||||
return 0;
|
||||
}
|
||||
@@ -37,4 +37,4 @@ class RelocatableObjectsService : IServiceObject {
|
||||
std::tuple<Result> load_nrr(PidDescriptor pid_desc, u64 nrr_address, u64 nrr_size);
|
||||
std::tuple<Result> unload_nrr(PidDescriptor pid_desc, u64 nrr_address);
|
||||
std::tuple<Result> initialize(PidDescriptor pid_desc, CopiedHandle process_h);
|
||||
};
|
||||
};
|
||||
|
||||
@@ -7,10 +7,10 @@ enum ShellServiceCmd {
|
||||
Shell_Cmd_ClearLaunchQueue = 1
|
||||
};
|
||||
|
||||
class ShellService : IServiceObject {
|
||||
class ShellService final : IServiceObject {
|
||||
public:
|
||||
virtual Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size);
|
||||
virtual Result handle_deferred() {
|
||||
Result dispatch(IpcParsedCommand &r, IpcCommand &out_c, u64 cmd_id, u8 *pointer_buffer, size_t pointer_buffer_size) override;
|
||||
Result handle_deferred() override {
|
||||
/* This service will never defer. */
|
||||
return 0;
|
||||
}
|
||||
@@ -19,4 +19,4 @@ class ShellService : IServiceObject {
|
||||
/* Actual commands. */
|
||||
std::tuple<Result> add_title_to_launch_queue(u64 tid, InPointer<char> args);
|
||||
std::tuple<Result> clear_launch_queue(u64 dat);
|
||||
};
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user