libstrat: fix compilation without pre-compiled header/without lto

libraries/libstratosphere/include/stratosphere/ncm/ncm_content_info_data.hpp

@@ -40,11 +40,11 @@ namespace ams::ncm {
             return this->info.GetId();
         }
 
-        constexpr const ContentType GetType() const {
+        constexpr ContentType GetType() const {
             return this->info.GetType();
         }
 
-        constexpr const u8 GetIdOffset() const {
+        constexpr u8 GetIdOffset() const {
             return this->info.GetIdOffset();
         }
     };
@@ -68,15 +68,15 @@ namespace ams::ncm {
             return this->info.GetId();
         }
 
-        constexpr const u64 GetSize() const {
+        constexpr u64 GetSize() const {
             return this->info.GetSize();
         }
 
-        constexpr const ContentType GetType() const {
+        constexpr ContentType GetType() const {
             return this->info.GetType();
         }
 
-        constexpr const u8 GetIdOffset() const {
+        constexpr u8 GetIdOffset() const {
             return this->info.GetIdOffset();
         }
 
@@ -84,15 +84,15 @@ namespace ams::ncm {
             return this->placeholder_id;
         }
 
-        constexpr const ContentMetaType GetContentMetaType() const {
+        constexpr ContentMetaType GetContentMetaType() const {
             return this->meta_type;
         }
 
-        constexpr const InstallState GetInstallState() const {
+        constexpr InstallState GetInstallState() const {
             return this->install_state;
         }
 
-        constexpr const StorageId GetStorageId() const {
+        constexpr StorageId GetStorageId() const {
             return this->storage_id;
         }
 

libraries/libstratosphere/include/stratosphere/ncm/ncm_content_manager_impl.hpp

@@ -51,6 +51,7 @@ namespace ams::ncm {
             }
 
             virtual void DeallocateImpl(void *buffer, size_t size, size_t alignment) override {
+                AMS_UNUSED(size, alignment);
                 return this->allocator.Free(buffer);
             }
 

libraries/libstratosphere/include/stratosphere/ncm/ncm_content_meta_id.hpp

@@ -39,7 +39,7 @@ namespace ams::ncm {
         return ApplicationId::Start <= program_id && program_id <= ApplicationId::End;
     }
 
-    inline constexpr bool IsApplicationId(const ApplicationId &id) {
+    inline constexpr bool IsApplicationId(const ApplicationId &) {
         return true;
     }
 

libraries/libstratosphere/include/stratosphere/ncm/ncm_install_task_base.hpp

@@ -164,7 +164,7 @@ namespace ams::ncm {
             Result VerifyAllNotCommitted(const StorageContentMetaKey *keys, s32 num_keys);
 
             virtual Result PrepareInstallContentMetaData() = 0;
-            virtual Result GetLatestVersion(util::optional<u32> *out_version, u64 id) { return ncm::ResultContentMetaNotFound(); }
+            virtual Result GetLatestVersion(util::optional<u32> *out_version, u64 id) { AMS_UNUSED(out_version, id); return ncm::ResultContentMetaNotFound(); }
 
             virtual Result OnExecuteComplete() { return ResultSuccess(); }
 

libraries/libstratosphere/include/stratosphere/ncm/ncm_system_content_meta_id.hpp

@@ -127,7 +127,7 @@ namespace ams::ncm {
         return program_id == AtmosphereProgramId::Mitm || program_id == AtmosphereProgramId::AtmosphereLogManager;
     }
 
-    inline constexpr bool IsSystemProgramId(const AtmosphereProgramId &program_id) {
+    inline constexpr bool IsSystemProgramId(const AtmosphereProgramId &) {
         return true;
     }
 
@@ -213,7 +213,7 @@ namespace ams::ncm {
         return (SystemProgramId::Start <= program_id && program_id <= SystemProgramId::End) || IsAtmosphereProgramId(program_id);
     }
 
-    inline constexpr bool IsSystemProgramId(const SystemProgramId &program_id) {
+    inline constexpr bool IsSystemProgramId(const SystemProgramId &) {
         return true;
     }
 
@@ -318,7 +318,7 @@ namespace ams::ncm {
         return SystemDataId::Start <= data_id && data_id <= SystemDataId::End;
     }
 
-    inline constexpr bool IsSystemDataId(const SystemDataId &data_id) {
+    inline constexpr bool IsSystemDataId(const SystemDataId &) {
         return true;
     }
 
@@ -410,7 +410,7 @@ namespace ams::ncm {
         return SystemAppletId::Start <= program_id && program_id <= SystemAppletId::End;
     }
 
-    inline constexpr bool IsSystemAppletId(const SystemAppletId &program_id) {
+    inline constexpr bool IsSystemAppletId(const SystemAppletId &) {
         return true;
     }
 
@@ -438,7 +438,7 @@ namespace ams::ncm {
         return SystemDebugAppletId::Start <= program_id && program_id <= SystemDebugAppletId::End;
     }
 
-    inline constexpr bool IsSystemDebugAppletId(const SystemDebugAppletId &program_id) {
+    inline constexpr bool IsSystemDebugAppletId(const SystemDebugAppletId &) {
         return true;
     }
 
@@ -496,7 +496,7 @@ namespace ams::ncm {
                id == LibraryAppletId::MyPage;
     }
 
-    inline constexpr bool IsLibraryAppletId(const LibraryAppletId &id) {
+    inline constexpr bool IsLibraryAppletId(const LibraryAppletId &) {
         return true;
     }
 
@@ -536,7 +536,7 @@ namespace ams::ncm {
                id == WebAppletId::WifiWebAuth;
     }
 
-    inline constexpr bool IsWebAppletId(const WebAppletId &id) {
+    inline constexpr bool IsWebAppletId(const WebAppletId &) {
         return true;
     }