stratosphere: In-class initialize members

Same thing, less code, less boilerplate.
This commit is contained in:
Léo Lam
2018-07-02 16:26:03 +02:00
committed by SciresM
parent 5b3e8e1c5d
commit e088a2f414
8 changed files with 42 additions and 54 deletions

View File

@@ -14,11 +14,9 @@ struct CodeInfo {
class CodeList {
private:
static const size_t max_code_count = 0x10;
u32 code_count;
u32 code_count = 0;
CodeInfo code_infos[max_code_count];
public:
CodeList() : code_count(0) { }
public:
void ReadCodeRegionsFromProcess(Handle debug_handle, u64 pc, u64 lr);
void SaveToFile(FILE *f_report);
private:

View File

@@ -23,30 +23,27 @@ enum class CrashReportResult : Result {
class CrashReport {
private:
Handle debug_handle;
Handle debug_handle = INVALID_HANDLE;
bool has_extra_info;
Result result;
Result result = static_cast<Result>(CrashReportResult::IncompleteReport);
/* Attach Process Info. */
AttachProcessInfo process_info;
u64 dying_message_address;
u64 dying_message_size;
u8 dying_message[0x1000];
AttachProcessInfo process_info{};
u64 dying_message_address = 0;
u64 dying_message_size = 0;
u8 dying_message[0x1000]{};
static_assert(sizeof(dying_message) == 0x1000, "Incorrect definition for dying message!");
/* Exception Info. */
ExceptionInfo exception_info;
ExceptionInfo exception_info{};
ThreadInfo crashed_thread_info;
/* Extra Info. */
CodeList code_list;
ThreadList thread_list;
public:
CrashReport() : debug_handle(INVALID_HANDLE), result((Result)CrashReportResult::IncompleteReport), process_info{0}, dying_message_address(0),
dying_message_size(0), dying_message{0}, exception_info({}) { }
public:
void BuildReport(u64 pid, bool has_extra_info);
void SaveReport();
@@ -98,4 +95,4 @@ class CrashReport {
void EnsureReportDirectories();
bool GetCurrentTime(u64 *out);
};
};

View File

@@ -31,15 +31,13 @@ static_assert(sizeof(DebugThreadContext) == 0x320, "Incorrect DebugThreadContext
class ThreadInfo {
private:
DebugThreadContext context;
u64 thread_id;
u64 stack_top;
u64 stack_bottom;
u64 stack_trace[0x20];
u32 stack_trace_size;
public:
ThreadInfo() : context{0}, thread_id(0), stack_top(0), stack_bottom(0), stack_trace{0}, stack_trace_size(0) { }
DebugThreadContext context{};
u64 thread_id = 0;
u64 stack_top = 0;
u64 stack_bottom = 0;
u64 stack_trace[0x20]{};
u32 stack_trace_size = 0;
public:
u64 GetPC() { return context.pc; }
u64 GetLR() { return context.lr; }
u64 GetId() { return thread_id; }
@@ -54,11 +52,9 @@ class ThreadInfo {
class ThreadList {
private:
static const size_t max_thread_count = 0x60;
u32 thread_count;
u32 thread_count = 0;
ThreadInfo thread_infos[max_thread_count];
public:
ThreadList() : thread_count(0) { }
public:
void SaveToFile(FILE *f_report);
void DumpBinary(FILE *f_bin, u64 crashed_id);
void ReadThreadsFromProcess(Handle debug_handle, bool is_64_bit);