ams: use R_SUCCEED, R_THROW globally

libraries/libstratosphere/source/sf/cmif/sf_cmif_domain_manager.cpp

@@ -44,7 +44,7 @@ namespace ams::sf::cmif {
             AMS_ABORT_UNLESS(entry->owner == nullptr);
             out_ids[i] = m_manager->m_entry_manager.GetId(entry);
         }
-        return ResultSuccess();
+        R_SUCCEED();
     }
 
     void ServerDomainManager::Domain::ReserveSpecificIds(const DomainObjectId *ids, size_t count) {

libraries/libstratosphere/source/sf/cmif/sf_cmif_domain_service_object.cpp

@@ -55,7 +55,7 @@ namespace ams::sf::cmif {
             case CmifDomainRequestType_Close:
                 /* TODO: N doesn't error check here. Should we? */
                 domain->UnregisterObject(target_object_id);
-                return ResultSuccess();
+                R_SUCCEED();
             default:
                 return sf::cmif::ResultInvalidInHeader();
         }
@@ -103,7 +103,7 @@ namespace ams::sf::cmif {
 
                 /* If the object is in the domain, close our copy of it. Mitm objects are required to close their associated domain id, so this shouldn't cause desynch. */
                 domain->UnregisterObject(target_object_id);
-                return ResultSuccess();
+                R_SUCCEED();
             }
             default:
                 return sf::cmif::ResultInvalidInHeader();
@@ -125,7 +125,7 @@ namespace ams::sf::cmif {
         for (size_t i = 0; i < this->GetInObjectCount(); i++) {
             in_objects[i] = m_domain->GetObject(m_in_object_ids[i]);
         }
-        return ResultSuccess();
+        R_SUCCEED();
     }
 
     HipcRequest DomainServiceObjectProcessor::PrepareForReply(const cmif::ServiceDispatchContext &ctx, PointerAndSize &out_raw_data, const ServerMessageRuntimeMetadata runtime_metadata) {

libraries/libstratosphere/source/sf/cmif/sf_cmif_service_dispatch.cpp

@@ -117,7 +117,7 @@ namespace ams::sf::cmif {
         /* Write output header to raw data. */
         *out_header = CmifOutHeader{OutHeaderMagic, 0, command_result.GetValue(), interface_id_for_debug};
 
-        return ResultSuccess();
+        R_SUCCEED();
     }
 
     #if AMS_SF_MITM_SUPPORTED
@@ -164,7 +164,7 @@ namespace ams::sf::cmif {
         /* Write output header to raw data. */
         *out_header = CmifOutHeader{OutHeaderMagic, 0, command_result.GetValue(), interface_id_for_debug};
 
-        return ResultSuccess();
+        R_SUCCEED();
     }
     #endif