ams: use R_SUCCEED, R_THROW globally
This commit is contained in:
@@ -27,7 +27,7 @@ namespace ams::fssrv::fscreator {
|
||||
|
||||
/* Set the output. */
|
||||
*out = std::move(fs);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -64,7 +64,7 @@ namespace ams::fssrv::fscreator {
|
||||
|
||||
/* Set the output. */
|
||||
*out = std::move(fs);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -29,7 +29,7 @@ namespace ams::fssrv::fscreator {
|
||||
/* Set the out storage. */
|
||||
*out = std::move(storage);
|
||||
*out_splitter = std::move(splitter);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
Result StorageOnNcaCreator::CreateWithPatch(std::shared_ptr<fs::IStorage> *out, std::shared_ptr<fssystem::IAsynchronousAccessSplitter> *out_splitter, fssystem::NcaFsHeaderReader *out_header_reader, std::shared_ptr<fssystem::NcaReader> original_nca_reader, std::shared_ptr<fssystem::NcaReader> current_nca_reader, s32 index) {
|
||||
@@ -44,7 +44,7 @@ namespace ams::fssrv::fscreator {
|
||||
/* Set the out storage. */
|
||||
*out = std::move(storage);
|
||||
*out_splitter = std::move(splitter);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
Result StorageOnNcaCreator::CreateNcaReader(std::shared_ptr<fssystem::NcaReader> *out, std::shared_ptr<fs::IStorage> storage) {
|
||||
@@ -57,7 +57,7 @@ namespace ams::fssrv::fscreator {
|
||||
|
||||
/* Set the output. */
|
||||
*out = std::move(reader);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
#if !defined(ATMOSPHERE_BOARD_NINTENDO_NX)
|
||||
@@ -73,7 +73,7 @@ namespace ams::fssrv::fscreator {
|
||||
/* Set the out storage. */
|
||||
*out = std::move(storage);
|
||||
*out_splitter = std::move(splitter);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
Result StorageOnNcaCreator::CreateWithPatchWithContext(std::shared_ptr<fs::IStorage> *out, std::shared_ptr<fssystem::IAsynchronousAccessSplitter> *out_splitter, fssystem::NcaFsHeaderReader *out_header_reader, void *ctx, std::shared_ptr<fssystem::NcaReader> original_nca_reader, std::shared_ptr<fssystem::NcaReader> current_nca_reader, s32 index) {
|
||||
@@ -88,7 +88,7 @@ namespace ams::fssrv::fscreator {
|
||||
/* Set the out storage. */
|
||||
*out = std::move(storage);
|
||||
*out_splitter = std::move(splitter);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
Result StorageOnNcaCreator::CreateByRawStorage(std::shared_ptr<fs::IStorage> *out, std::shared_ptr<fssystem::IAsynchronousAccessSplitter> *out_splitter, const fssystem::NcaFsHeaderReader *header_reader, std::shared_ptr<fs::IStorage> raw_storage, void *ctx, std::shared_ptr<fssystem::NcaReader> nca_reader) {
|
||||
|
||||
@@ -66,7 +66,7 @@ namespace ams::fssrv {
|
||||
R_TRY(this->AcceptImpl(server, impl::GetInvalidProgramRegistryServiceObject()));
|
||||
}
|
||||
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
break;
|
||||
case PortIndex_FileSystemProxyForLoader:
|
||||
@@ -81,7 +81,7 @@ namespace ams::fssrv {
|
||||
R_TRY(this->AcceptImpl(server, impl::GetInvalidFileSystemProxyForLoaderServiceObject()));
|
||||
}
|
||||
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
break;
|
||||
AMS_UNREACHABLE_DEFAULT_CASE();
|
||||
|
||||
@@ -71,7 +71,7 @@ namespace ams::fssrv {
|
||||
/* Set our process id. */
|
||||
m_process_id = client_pid.GetValue().value;
|
||||
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
Result ProgramRegistryImpl::SetEnabledProgramVerification(bool en) {
|
||||
|
||||
@@ -44,7 +44,7 @@ namespace ams::fssrv::impl {
|
||||
/* Add the node to the registry. */
|
||||
m_program_info_list.push_back(*new_node.release());
|
||||
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
Result ProgramRegistryManager::UnregisterProgram(u64 process_id) {
|
||||
@@ -56,12 +56,12 @@ namespace ams::fssrv::impl {
|
||||
if (node.program_info->Contains(process_id)) {
|
||||
m_program_info_list.erase(m_program_info_list.iterator_to(node));
|
||||
delete std::addressof(node);
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
}
|
||||
|
||||
/* We couldn't find/unregister the process's node. */
|
||||
return fs::ResultInvalidArgument();
|
||||
R_THROW(fs::ResultInvalidArgument());
|
||||
}
|
||||
|
||||
Result ProgramRegistryManager::GetProgramInfo(std::shared_ptr<ProgramInfo> *out, u64 process_id) {
|
||||
@@ -71,19 +71,19 @@ namespace ams::fssrv::impl {
|
||||
/* Check if we're getting permissions for an initial program. */
|
||||
if (IsInitialProgram(process_id)) {
|
||||
*out = ProgramInfo::GetProgramInfoForInitialProcess();
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
|
||||
/* Find a matching node. */
|
||||
for (const auto &node : m_program_info_list) {
|
||||
if (node.program_info->Contains(process_id)) {
|
||||
*out = node.program_info;
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
}
|
||||
|
||||
/* We didn't find the program info. */
|
||||
return fs::ResultProgramInfoNotFound();
|
||||
R_THROW(fs::ResultProgramInfoNotFound());
|
||||
}
|
||||
|
||||
Result ProgramRegistryManager::GetProgramInfoByProgramId(std::shared_ptr<ProgramInfo> *out, u64 program_id) {
|
||||
@@ -94,12 +94,12 @@ namespace ams::fssrv::impl {
|
||||
for (const auto &node : m_program_info_list) {
|
||||
if (node.program_info->GetProgramIdValue() == program_id) {
|
||||
*out = node.program_info;
|
||||
return ResultSuccess();
|
||||
R_SUCCEED();
|
||||
}
|
||||
}
|
||||
|
||||
/* We didn't find the program info. */
|
||||
return fs::ResultProgramInfoNotFound();
|
||||
R_THROW(fs::ResultProgramInfoNotFound());
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user