OmniNX/Atmosphere
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ams: prefer construct_at/destroy_at over placement new/explicit destructor

Browse Source
This commit is contained in:
Michael Scire
2021-03-21 20:30:40 -07:00
parent aff0da9427
commit d84dcb653d
49 changed files with 217 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/libstratosphere/source/powctl/powctl_session_api.cpp
View File

@@ -38,7 +38,7 @@ namespace ams::powctl {
}
void DestroySession(Session &session) {
GetSessionImpl(session).~SessionImpl();
std::destroy_at(std::addressof(GetSessionImpl(session)));
session.has_session = false;
}
@@ -69,11 +69,11 @@ namespace ams::powctl {
DestroySessionIfNecessary(*out);
/* Construct the session. */
new (std::addressof(GetSessionImpl(*out))) impl::SessionImpl;
auto *session = std::construct_at(std::addressof(GetSessionImpl(*out)));
auto guard = SCOPE_GUARD { DestroySessionIfNecessary(*out); };
/* Try to open the session. */
R_TRY(ddsf::OpenSession(device, std::addressof(GetSessionImpl(*out)), access_mode));
R_TRY(ddsf::OpenSession(device, session, access_mode));
/* We opened the session! */
guard.Cancel();