OmniNX/Atmosphere
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libstrat: enable -Wextra, -Werror

Browse Source 
This caught an embarrassingly large number of bugs.
This commit is contained in:
Michael Scire
2021-10-06 15:20:48 -07:00
parent e1fbf27398
commit 7ca83c9d3b
160 changed files with 691 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libraries/libstratosphere/source/os/impl/os_multiple_wait_impl.cpp
View File

@@ -142,6 +142,7 @@ namespace ams::os::impl {
for (MultiWaitHolderBase &holder_base : this->multi_wait_list) {
if (auto handle = holder_base.GetHandle(); handle != os::InvalidNativeHandle) {
AMS_ASSERT(count < num);
AMS_UNUSED(num);
out_handles[count] = handle;
out_objects[count] = &holder_base;

4
libraries/libstratosphere/source/os/impl/os_multiple_wait_target_impl.os.horizon.cpp
View File

@@ -20,6 +20,8 @@
namespace ams::os::impl {
Result MultiWaitHorizonImpl::WaitSynchronizationN(s32 *out_index, s32 num, NativeHandle arr[], s32 array_size, s64 ns) {
AMS_UNUSED(array_size);
AMS_ASSERT(!(num == 0 && ns == 0));
s32 index = MultiWaitImpl::WaitInvalid;
@@ -38,6 +40,8 @@ namespace ams::os::impl {
}
Result MultiWaitHorizonImpl::ReplyAndReceiveN(s32 *out_index, s32 num, NativeHandle arr[], s32 array_size, s64 ns, NativeHandle reply_target) {
AMS_UNUSED(array_size);
/* NOTE: Nintendo does not initialize this value, which seems like it can cause incorrect behavior. */
s32 index = MultiWaitImpl::WaitInvalid;
static_assert(MultiWaitImpl::WaitInvalid != -1);

2
libraries/libstratosphere/source/os/impl/os_process_handle_impl.os.horizon.hpp
View File

@@ -29,7 +29,7 @@ namespace ams::os::impl {
}
static ALWAYS_INLINE Result GetProgramId(ncm::ProgramId *out, NativeHandle handle) {
return svc::GetInfo(std::addressof(out->value), svc::InfoType_ProgramId, svc::PseudoHandle::CurrentProcess, 0);
return svc::GetInfo(std::addressof(out->value), svc::InfoType_ProgramId, handle, 0);
}
};

2
libraries/libstratosphere/source/os/impl/os_thread_manager_impl.os.horizon.cpp
View File

@@ -71,7 +71,7 @@ namespace ams::os::impl {
s32 count = 0;
while (true) {
R_TRY_CATCH(::threadCreate(thread->thread_impl, reinterpret_cast<::ThreadFunc>(&InvokeThread), thread, thread->stack, thread->stack_size, ConvertToHorizonPriority(thread->base_priority), ideal_core)) {
R_TRY_CATCH(::threadCreate(thread->thread_impl, reinterpret_cast<::ThreadFunc>(reinterpret_cast<void *>(&InvokeThread)), thread, thread->stack, thread->stack_size, ConvertToHorizonPriority(thread->base_priority), ideal_core)) {
R_CATCH(svc::ResultOutOfResource) {
if ((++count) < 10) {
os::SleepThread(TimeSpan::FromMilliSeconds(10));

2
libraries/libstratosphere/source/os/impl/os_thread_manager_impl.os.horizon.hpp
View File

@@ -51,7 +51,7 @@ namespace ams::os::impl {
/* TODO: void GetThreadContextUnsafe(ThreadContextInfo *out_context, const ThreadType *thread); */
void NotifyThreadNameChangedImpl(const ThreadType *thread) const { /* ... */ }
void NotifyThreadNameChangedImpl(const ThreadType *thread) const { AMS_UNUSED(thread); }
void SetCurrentThread(ThreadType *thread) const {
g_current_thread_pointer = thread;

2
libraries/libstratosphere/source/os/os_memory_heap.cpp
View File

@@ -18,10 +18,12 @@
namespace ams::os {
Result AllocateMemoryBlock(uintptr_t *out_address, size_t size) {
AMS_UNUSED(out_address, size);
AMS_ABORT("Not implemented yet");
}
void FreeMemoryBlock(uintptr_t address, size_t size) {
AMS_UNUSED(address, size);
AMS_ABORT("Not implemented yet");
}

12
libraries/libstratosphere/source/os/os_mutex.cpp
View File

@@ -23,7 +23,7 @@ namespace ams::os {
#ifdef ATMOSPHERE_BUILD_FOR_AUDITING
void PushAndCheckLockLevel(MutexType *mutex) {
void PushAndCheckLockLevel(const MutexType *mutex) {
/* If auditing isn't specified, don't bother. */
if (mutex->lock_level == 0) {
return;
@@ -32,7 +32,7 @@ namespace ams::os {
/* TODO: Implement mutex level auditing. */
}
void PopAndCheckLockLevel(MutexType *mutex) {
void PopAndCheckLockLevel(const MutexType *mutex) {
/* If auditing isn't specified, don't bother. */
if (mutex->lock_level == 0) {
return;
@@ -43,12 +43,12 @@ namespace ams::os {
#else
void PushAndCheckLockLevel(MutexType *mutex) {
/* ... */
void PushAndCheckLockLevel(const MutexType *mutex) {
AMS_UNUSED(mutex);
}
void PopAndCheckLockLevel(MutexType *mutex) {
/* ... */
void PopAndCheckLockLevel(const MutexType *mutex) {
AMS_UNUSED(mutex);
}
#endif

2
libraries/libstratosphere/source/os/os_thread.cpp
View File

@@ -38,6 +38,8 @@ namespace ams::os {
AMS_ASSERT(util::IsAligned(reinterpret_cast<uintptr_t>(stack), ThreadStackAlignment));
AMS_ASSERT(stack_size > 0);
AMS_ASSERT(util::IsAligned(stack_size, ThreadStackAlignment));
AMS_UNUSED(thread, stack, stack_size, priority);
}
}

2
libraries/libstratosphere/source/os/os_thread_local_storage_api.cpp
View File

@@ -26,7 +26,7 @@ namespace ams::os {
}
Result AllocateTlsSlot(TlsSlot *out, TlsDestructor destructor) {
s32 slot = ::threadTlsAlloc(reinterpret_cast<LibnxTlsDestructor>(destructor));
s32 slot = ::threadTlsAlloc(reinterpret_cast<LibnxTlsDestructor>(reinterpret_cast<void *>(destructor)));
R_UNLESS(slot >= 0, os::ResultOutOfResource());
*out = { static_cast<u32>(slot) };