libstrat: enable -Wextra, -Werror

This caught an embarrassingly large number of bugs.

libraries/libstratosphere/source/htclow/ctrl/htclow_ctrl_service.cpp

@@ -107,7 +107,7 @@ namespace ams::htclow::ctrl {
                 R_UNLESS(header.body_size == 0, htclow::ResultProtocolError());
                 break;
             case HtcctrlPacketType_ReadyFromHost:
-                R_UNLESS(0 <= header.body_size && header.body_size <= sizeof(HtcctrlPacketBody), htclow::ResultProtocolError());
+                R_UNLESS(header.body_size <= sizeof(HtcctrlPacketBody), htclow::ResultProtocolError());
                 break;
             default:
                 return htclow::ResultProtocolError();

libraries/libstratosphere/source/htclow/ctrl/htclow_json.cpp

@@ -26,6 +26,8 @@ namespace ams::htclow::ctrl {
     }
 
     bool JsonHandler::Key(const Ch *str, rapidjson::SizeType len, bool copy) {
+        AMS_UNUSED(len, copy);
+
         if (m_state == State::ParseObject) {
             if (!util::Strncmp(str, ChannelKey, sizeof(ChannelKey))) {
                 m_state = State::ParseServiceChannels;
@@ -45,6 +47,8 @@ namespace ams::htclow::ctrl {
     }
 
     bool JsonHandler::String(const Ch *str, rapidjson::SizeType len, bool copy) {
+        AMS_UNUSED(len, copy);
+
         if (m_state == State::ParseServiceChannelsArray && *m_num_strings < m_max_strings) {
             m_strings[(*m_num_strings)++] = str;
         }

libraries/libstratosphere/source/htclow/ctrl/htclow_service_channel_parser.cpp

@@ -24,6 +24,8 @@ namespace ams::htclow::ctrl {
         constexpr auto JsonParseFlags = rapidjson::kParseTrailingCommasFlag | rapidjson::kParseInsituFlag;
 
         void ParseBody(s16 *out_version, const char **out_channels, int *out_num_channels, int max_channels, void *str, size_t str_size) {
+            AMS_UNUSED(str_size);
+
             /* Create JSON handler. */
             JsonHandler json_handler(out_version, out_channels, out_num_channels, max_channels);
 

libraries/libstratosphere/source/htclow/driver/htclow_socket_discovery_manager.cpp

@@ -59,7 +59,7 @@ namespace ams::htclow::driver {
     }
 
     void SocketDiscoveryManager::OnSocketAcceptBegin(u16 port) {
-        /* ... */
+        AMS_UNUSED(port);
     }
 
     void SocketDiscoveryManager::OnSocketAcceptEnd() {

libraries/libstratosphere/source/htclow/driver/htclow_usb_impl.cpp

@@ -272,7 +272,7 @@ namespace ams::htclow::driver {
             return ResultSuccess();
         }
 
-        void UsbIndicationThreadFunction(void *arg) {
+        void UsbIndicationThreadFunction(void *) {
             /* Get the state change event. */
             os::SystemEventType *state_change_event = g_ds_client.GetStateChangeEvent();
 

libraries/libstratosphere/source/htclow/mux/htclow_mux.cpp

@@ -157,6 +157,8 @@ namespace ams::htclow::mux {
     }
 
     bool Mux::IsSendable(PacketType packet_type) const {
+        AMS_UNUSED(packet_type);
+
         switch (m_state) {
             case MuxState::Normal:
                 return true;